Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h

Issue 2619173002: Remove most content from Interpolation (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h
diff --git a/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h b/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h
index 7f7cc0d061cd018392093c5d1d6525afe7f91e23..bdacb924bc4ddb10fa6933d6ab791f51a28fe1bf 100644
--- a/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h
+++ b/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h
@@ -40,7 +40,7 @@ class CORE_EXPORT InvalidatableInterpolation : public Interpolation {
InvalidatableInterpolation(PropertyHandle property,
PassRefPtr<PropertySpecificKeyframe> startKeyframe,
PassRefPtr<PropertySpecificKeyframe> endKeyframe)
- : Interpolation(nullptr, nullptr),
+ : Interpolation(),
m_property(property),
m_interpolationTypes(nullptr),
m_interpolationTypesVersion(0),
@@ -51,6 +51,11 @@ class CORE_EXPORT InvalidatableInterpolation : public Interpolation {
using ConversionCheckers = InterpolationType::ConversionCheckers;
+ InterpolableValue* getCachedValueForTesting() const final {
+ // TODO(suzyh): Add meaningful implementation here
+ NOTREACHED();
+ return nullptr;
+ }
std::unique_ptr<TypedInterpolationValue> maybeConvertUnderlyingValue(
const InterpolationEnvironment&) const;
const TypedInterpolationValue* ensureValidConversion(

Powered by Google App Engine
This is Rietveld 408576698