Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: third_party/WebKit/Source/core/animation/Interpolation.h

Issue 2619173002: Remove most content from Interpolation (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/Interpolation.h
diff --git a/third_party/WebKit/Source/core/animation/Interpolation.h b/third_party/WebKit/Source/core/animation/Interpolation.h
index 702d01d8f55d79cbfce79f19c33be7017eb5ea1e..2b49062570445ae9925bf790b698a53c07b99e84 100644
--- a/third_party/WebKit/Source/core/animation/Interpolation.h
+++ b/third_party/WebKit/Source/core/animation/Interpolation.h
@@ -21,9 +21,9 @@ class CORE_EXPORT Interpolation : public RefCounted<Interpolation> {
WTF_MAKE_NONCOPYABLE(Interpolation);
public:
- virtual ~Interpolation();
+ virtual ~Interpolation() {}
- virtual void interpolate(int iteration, double fraction);
+ virtual void interpolate(int iteration, double fraction) = 0;
virtual bool isInvalidatableInterpolation() const { return false; }
virtual bool isLegacyStyleInterpolation() const { return false; }
@@ -32,20 +32,9 @@ class CORE_EXPORT Interpolation : public RefCounted<Interpolation> {
virtual bool dependsOnUnderlyingValue() const { return false; }
protected:
- const std::unique_ptr<InterpolableValue> m_start;
- const std::unique_ptr<InterpolableValue> m_end;
+ Interpolation() {}
- mutable double m_cachedFraction;
- mutable int m_cachedIteration;
- mutable std::unique_ptr<InterpolableValue> m_cachedValue;
-
- Interpolation(std::unique_ptr<InterpolableValue> start,
- std::unique_ptr<InterpolableValue> end);
-
- private:
- InterpolableValue* getCachedValueForTesting() const {
- return m_cachedValue.get();
- }
+ virtual InterpolableValue* getCachedValueForTesting() const = 0;
friend class AnimationInterpolableValueTest;
friend class AnimationInterpolationEffectTest;

Powered by Google App Engine
This is Rietveld 408576698