Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2617703004: Combine {Legacy,}StyleInterpolation (Closed)

Created:
3 years, 11 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 11 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Combine {Legacy,}StyleInterpolation This patch removes the distinction between StyleInterpolation and LegacyStyleInterpolation, combining them into a single LegacyStyleInterpolation class. BUG=678875 Review-Url: https://codereview.chromium.org/2617703004 Cr-Commit-Position: refs/heads/master@{#442201} Committed: https://chromium.googlesource.com/chromium/src/+/10f8f0ea92fd3dd7303948a01662d64c09785479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -37 lines) Patch
M third_party/WebKit/Source/core/animation/Interpolation.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/LegacyStyleInterpolation.h View 2 chunks +17 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
suzyh_UTC10 (ex-contributor)
3 years, 11 months ago (2017-01-09 03:10:48 UTC) #3
alancutter (OOO until 2018)
lgtm
3 years, 11 months ago (2017-01-09 03:29:35 UTC) #4
suzyh_UTC10 (ex-contributor)
+sashab for core/css A follow-on from the previous patch. You're not imagining it, Sasha, the ...
3 years, 11 months ago (2017-01-09 04:03:09 UTC) #6
sashab
Haha StyleResolver.cpp lgtm again
3 years, 11 months ago (2017-01-09 05:10:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617703004/1
3 years, 11 months ago (2017-01-09 05:21:38 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 06:37:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/10f8f0ea92fd3dd7303948a01662...

Powered by Google App Engine
This is Rietveld 408576698