Remove unused code in InvalidatableInterpolation

Remove unused code in InvalidatableInterpolation

This patch removes two functions in InvalidatableInterpolation that are
unreached: apply and getCachedValueForTesting.

Since InvalidatableInterpolation has cached values, I had originally intended to
supply a meaningful implementation for getCachedValueForTesting. However, after
further consultation, I'm instead removing the virtual function from the
Interpolation superclass and modifying the tests that use it to make it explicit
that they will be executing LegacyStyleInterpolation::getCachedValueForTesting.

BUG=678875
Review-Url: https://codereview.chromium.org/2627793002
Cr-Commit-Position: refs/heads/master@{#443055}
Committed: https://chromium.googlesource.com/chromium/src/+/ff407634505cc3c6203ed2f746000b6d6eea79b6

[suzyh_UTC10 (ex-contributor), 2017-01-11 04:05:20]

suzyh@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-11 04:27:33]

lgtm after comment.

https://codereview.chromium.org/2627793002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/InterpolationEffectTest.cpp
(right):

https://codereview.chromium.org/2627793002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/InterpolationEffectTest.cpp:48: return
0.0;
Remove this branch, don't check just cast, the macro asserts the type for you.

[suzyh_UTC10 (ex-contributor), 2017-01-11 04:31:03]

On 2017/01/11 at 04:27:33, alancutter wrote:
> lgtm after comment.
> 
>
https://codereview.chromium.org/2627793002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/animation/InterpolationEffectTest.cpp
(right):
> 
>
https://codereview.chromium.org/2627793002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/animation/InterpolationEffectTest.cpp:48:
return 0.0;
> Remove this branch, don't check just cast, the macro asserts the type for you.

Thanks, done.

[suzyh_UTC10 (ex-contributor), 2017-01-11 04:52:13]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-01-11 04:52:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2627793002/#ps20001
(title: "Simplify test in response to review")

[commit-bot: I haz the power, 2017-01-11 04:52:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 06:23:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 06:23:49]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[suzyh_UTC10 (ex-contributor), 2017-01-11 23:30:20]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2017-01-11 23:31:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 23:40:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484177420493260,
"parent_rev": "0f71ff05b2c969aa3074d1b7e80da003051dbd15", "commit_rev":
"ff407634505cc3c6203ed2f746000b6d6eea79b6"}

[commit-bot: I haz the power, 2017-01-11 23:41:28]

Description was changed from

==========
Remove unused code in InvalidatableInterpolation

This patch removes two functions in InvalidatableInterpolation that are
unreached: apply and getCachedValueForTesting.

Since InvalidatableInterpolation has cached values, I had originally intended to
supply a meaningful implementation for getCachedValueForTesting. However, after
further consultation, I'm instead removing the virtual function from the
Interpolation superclass and modifying the tests that use it to make it explicit
that they will be executing LegacyStyleInterpolation::getCachedValueForTesting.

BUG=678875
==========

to

==========
Remove unused code in InvalidatableInterpolation

This patch removes two functions in InvalidatableInterpolation that are
unreached: apply and getCachedValueForTesting.

Since InvalidatableInterpolation has cached values, I had originally intended to
supply a meaningful implementation for getCachedValueForTesting. However, after
further consultation, I'm instead removing the virtual function from the
Interpolation superclass and modifying the tests that use it to make it explicit
that they will be executing LegacyStyleInterpolation::getCachedValueForTesting.

BUG=678875

Review-Url: https://codereview.chromium.org/2627793002
Cr-Commit-Position: refs/heads/master@{#443055}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff407634505cc3c6203ed2f74600...
==========

[commit-bot: I haz the power, 2017-01-11 23:41:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ff407634505cc3c6203ed2f74600...