bindings: Don't throw a TypeError when 'null' is passed to nullable callback function

bindings: Don't throw a TypeError when 'null' is passed to nullable callback function

'null' and 'undefined' are valid values for nullable callback function parameters.

BUG=675859
Committed: https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172
Cr-Commit-Position: refs/heads/master@{#441597}

[bashi, 2017-01-05 01:46:50]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 01:47:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 03:43:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 03:43:03]

Dry run: This issue passed the CQ dry run.

[bashi, 2017-01-05 04:20:16]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org, peria@chromium.org, yukishiino@chromium.org

[bashi, 2017-01-05 04:20:16]

PTAL

Context: https://bugs.chromium.org/p/chromium/issues/detail?id=675859#c13

[haraken, 2017-01-05 04:28:39]

LGTM

[peria, 2017-01-05 04:39:18]

https://codereview.chromium.org/2617653002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl (right):

https://codereview.chromium.org/2617653002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl:180: if ({% if
argument.is_nullable %}!isUndefinedOrNull(info[{{argument.index}}]) && {% endif
%}!(info[{{argument.index}}]->IsObject() &&
v8::Local<v8::Object>::Cast(info[{{argument.index}}])->IsCallable())) {
who tests this new {% if %} branch in run-binding-test?

[bashi, 2017-01-05 04:41:31]

https://codereview.chromium.org/2617653002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl (right):

https://codereview.chromium.org/2617653002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl:180: if ({% if
argument.is_nullable %}!isUndefinedOrNull(info[{{argument.index}}]) && {% endif
%}!(info[{{argument.index}}]->IsObject() &&
v8::Local<v8::Object>::Cast(info[{{argument.index}}])->IsCallable())) {
On 2017/01/05 04:39:18, peria wrote:
> who tests this new {% if %} branch in run-binding-test?

TestCallbackFunctions.voidMethodNullableCallbackFunctionInArg()

[peria, 2017-01-05 04:46:11]

On 2017/01/05 04:41:31, bashi wrote:
>
https://codereview.chromium.org/2617653002/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl (right):
> 
>
https://codereview.chromium.org/2617653002/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl:180: if ({% if
> argument.is_nullable %}!isUndefinedOrNull(info[{{argument.index}}]) && {%
endif
> %}!(info[{{argument.index}}]->IsObject() &&
> v8::Local<v8::Object>::Cast(info[{{argument.index}}])->IsCallable())) {
> On 2017/01/05 04:39:18, peria wrote:
> > who tests this new {% if %} branch in run-binding-test?
> 
> TestCallbackFunctions.voidMethodNullableCallbackFunctionInArg()

Thanks. I missed it.
LGTM

[Yuki, 2017-01-05 05:47:10]

LGTM.

[bashi, 2017-01-05 06:21:16]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2017-01-05 06:21:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 06:26:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483597276729990, "parent_rev":
"c38a5e49b5e5ed759961c6e0eca2d422b78b4291", "commit_rev":
"a80c5c002eaa23cf73d975423a199918a1067157"}

[commit-bot: I haz the power, 2017-01-05 06:27:04]

Description was changed from

==========
bindings: Don't throw a TypeError when 'null' is passed to nullable callback
function

'null' and 'undefined' are valid values for nullable callback function
parameters.

BUG=675859
==========

to

==========
bindings: Don't throw a TypeError when 'null' is passed to nullable callback
function

'null' and 'undefined' are valid values for nullable callback function
parameters.

BUG=675859

Review-Url: https://codereview.chromium.org/2617653002
==========

[commit-bot: I haz the power, 2017-01-05 06:27:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-05 06:29:05]

Description was changed from

==========
bindings: Don't throw a TypeError when 'null' is passed to nullable callback
function

'null' and 'undefined' are valid values for nullable callback function
parameters.

BUG=675859

Review-Url: https://codereview.chromium.org/2617653002
==========

to

==========
bindings: Don't throw a TypeError when 'null' is passed to nullable callback
function

'null' and 'undefined' are valid values for nullable callback function
parameters.

BUG=675859

Committed: https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172
Cr-Commit-Position: refs/heads/master@{#441597}
==========

[commit-bot: I haz the power, 2017-01-05 06:29:06]

Patchset 1 (id:??) landed as
https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172
Cr-Commit-Position: refs/heads/master@{#441597}