Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2617653002: bindings: Don't throw a TypeError when 'null' is passed to nullable callback function (Closed)

Created:
3 years, 11 months ago by bashi
Modified:
3 years, 11 months ago
Reviewers:
haraken, peria, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Don't throw a TypeError when 'null' is passed to nullable callback function 'null' and 'undefined' are valid values for nullable callback function parameters. BUG=675859 Committed: https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172 Cr-Commit-Position: refs/heads/master@{#441597}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -47 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/idl-callback-function-unittest.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_types.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl View 1 chunk +1 line, -1 line 2 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/CallbackFunctionTest.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/CallbackFunctionTest.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
bashi
PTAL Context: https://bugs.chromium.org/p/chromium/issues/detail?id=675859#c13
3 years, 11 months ago (2017-01-05 04:20:16 UTC) #6
haraken
LGTM
3 years, 11 months ago (2017-01-05 04:28:39 UTC) #7
peria
https://codereview.chromium.org/2617653002/diff/1/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl File third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl (right): https://codereview.chromium.org/2617653002/diff/1/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl#newcode180 third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl:180: if ({% if argument.is_nullable %}!isUndefinedOrNull(info[{{argument.index}}]) && {% endif %}!(info[{{argument.index}}]->IsObject() ...
3 years, 11 months ago (2017-01-05 04:39:18 UTC) #8
bashi
https://codereview.chromium.org/2617653002/diff/1/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl File third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl (right): https://codereview.chromium.org/2617653002/diff/1/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl#newcode180 third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl:180: if ({% if argument.is_nullable %}!isUndefinedOrNull(info[{{argument.index}}]) && {% endif %}!(info[{{argument.index}}]->IsObject() ...
3 years, 11 months ago (2017-01-05 04:41:31 UTC) #9
peria
On 2017/01/05 04:41:31, bashi wrote: > https://codereview.chromium.org/2617653002/diff/1/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl > File third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl (right): > > https://codereview.chromium.org/2617653002/diff/1/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl#newcode180 > ...
3 years, 11 months ago (2017-01-05 04:46:11 UTC) #10
Yuki
LGTM.
3 years, 11 months ago (2017-01-05 05:47:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617653002/1
3 years, 11 months ago (2017-01-05 06:21:36 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-05 06:27:05 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 06:29:06 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172
Cr-Commit-Position: refs/heads/master@{#441597}

Powered by Google App Engine
This is Rietveld 408576698