third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl - Issue 2617653002: bindings: Don't throw a TypeError when 'null' is passed to nullable callback function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

Issue 2617653002: bindings: Don't throw a TypeError when 'null' is passed to nullable callback function (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_types.py ('k') | third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl » ('j') | third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

index 412a9df6e81537ad6a75346ed36922528b74761e..abce755796d649ce8129f394306776281fc271a9 100644

--- a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

@@ -11,6 +11,13 @@

namespace blink {

+// static

+{{cpp_class}}* {{cpp_class}}::create(ScriptState* scriptState, v8::Local<v8::Value> callback){

+ if (isUndefinedOrNull(callback))

+ return nullptr;

+ return new {{cpp_class}}(scriptState, v8::Local<v8::Function>::Cast(callback));

{{cpp_class}}::{{cpp_class}}(ScriptState* scriptState, v8::Local<v8::Function> callback)

: m_scriptState(scriptState),

m_callback(scriptState->isolate(), this, callback) {