third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl - Issue 2617653002: bindings: Don't throw a TypeError when 'null' is passed to nullable callback function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

Issue 2617653002: bindings: Don't throw a TypeError when 'null' is passed to nullable callback function (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl » ('j') | third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl b/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

index 383cf40d9cee5ea88ece6b873343e7e0e8b9e8fb..133cfa1a53548c0e1b106792068d867b51404a4f 100644

--- a/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

@@ -18,9 +18,7 @@ class {{forward_declaration}};

class {{exported}}{{cpp_class}} final : public GarbageCollectedFinalized<{{cpp_class}}>, public TraceWrapperBase {

public:

- static {{cpp_class}}* create(ScriptState* scriptState, v8::Local<v8::Function> callback) {

- return new {{cpp_class}}(scriptState, callback);

- }

+ static {{cpp_class}}* create(ScriptState* scriptState, v8::Local<v8::Value> callback);

~{{cpp_class}}() = default;