third_party/WebKit/Source/bindings/scripts/v8_types.py - Issue 2617653002: bindings: Don't throw a TypeError when 'null' is passed to nullable callback function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 2617653002: bindings: Don't throw a TypeError when 'null' is passed to nullable callback function (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_types.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py

index ec7af0a77932b25708de186b51475696705c99ab..6dfd35c73bffcf4df93a99f1c385b7aeb0e04fd4 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py

@@ -585,7 +585,7 @@ def v8_value_to_cpp_value(idl_type, extended_attributes, v8_value, variable_name

cpp_expression_format = 'V8{idl_type}::toImpl({isolate}, {v8_value}, {variable_name}, exceptionState)'

elif idl_type.is_callback_function:

cpp_expression_format = (

- '{idl_type}::create(ScriptState::current({isolate}), v8::Local<v8::Function>::Cast({v8_value}))')

+ '{idl_type}::create(ScriptState::current({isolate}), {v8_value})')

else:

cpp_expression_format = (

'V8{idl_type}::toImplWithTypeCheck({isolate}, {v8_value})')