third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h - Issue 2617653002: bindings: Don't throw a TypeError when 'null' is passed to nullable callback function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h

Issue 2617653002: bindings: Don't throw a TypeError when 'null' is passed to nullable callback function (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h b/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h

index 5a1ad696330ffeaa5c23c0df57ca7b24bfeac23f..5d5857324955a146ab8e8d43079c2c85a2691319 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h

@@ -25,9 +25,7 @@ class ScriptState;

class CORE_EXPORT VoidCallbackFunction final : public GarbageCollectedFinalized<VoidCallbackFunction>, public TraceWrapperBase {

public:

- static VoidCallbackFunction* create(ScriptState* scriptState, v8::Local<v8::Function> callback) {

- return new VoidCallbackFunction(scriptState, callback);

- }

+ static VoidCallbackFunction* create(ScriptState* scriptState, v8::Local<v8::Value> callback);

~VoidCallbackFunction() = default;