Add deprecation message for top navigations from sandbox w/ 'allow-top-navigation' but no gesture

Add deprecation message for top navigations from sandboxed iframes w/ 'allow-top-navigation' but having not received user gesture.

This is for this intent to implement/ship feature:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Flt2IixYQK4

BUG=662506

[Bin Lu, 2017-01-07 06:24:22]

Description was changed from

==========
Add deprecation message for top navigations from sandboxed iframes w/
'allow-top-navigation' but having not received user gesture.

This is for this intent to implement/ship feature:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Flt2IixYQK4

BUG=662506
==========

to

==========
Add deprecation message for top navigations from sandboxed iframes w/
'allow-top-navigation' but having not received user gesture.

This is for this intent to implement/ship feature:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Flt2IixYQK4

BUG=662506
==========

[Bin Lu, 2017-01-07 06:24:22]

binlu@google.com changed reviewers:
+ japhet@chromium.org, ojan@chromium.org, rbyers@chromium.org

[Bin Lu, 2017-01-07 06:25:10]

Does this look good to you? Is this still possible to merge this back to M56?

[Bin Lu, 2017-01-07 06:32:08]

The CQ bit was checked by binlu@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-07 06:32:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 07:50:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 07:50:51]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Bin Lu, 2017-01-08 15:46:35]

The CQ bit was checked by binlu@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-08 15:46:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-08 17:03:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-08 17:03:50]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Bin Lu, 2017-01-09 06:26:57]

The CQ bit was checked by binlu@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 06:27:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 08:07:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 08:07:02]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Bin Lu, 2017-01-10 17:56:26]

The CQ bit was checked by binlu@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 17:56:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bin Lu, 2017-01-10 17:57:13]

binlu@google.com changed reviewers:
+ mkwst@chromium.org

[Bin Lu, 2017-01-10 18:00:20]

Anyone has any idea on why the warning console message got truncated for some
tests in 	third_party/WebKit/LayoutTests/fast/frames?
There is no Frame URL or targetFrame URL any more in the console message:
 "CONSOLE WARNING: line 2: Frame with URL '5629582019395584."

But the test in
third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/ works fine:
eg., sandbox-WARN-top-navigation-without-user-gesture-expected.txt.

Thanks,
Bin


On 2017/01/07 06:25:10, Bin Lu wrote:
> Does this look good to you? Is this still possible to merge this back to M56?

[commit-bot: I haz the power, 2017-01-10 20:04:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 20:04:33]

Dry run: This issue passed the CQ dry run.

[ojan, 2017-01-10 22:50:53]

FYI, I'm waiting on our email thread about this to resolve before reviewing
since it might change what this patch does. I'm not sure at a quick glance why
the console message is getting truncated.

[Rick Byers, 2017-02-25 15:02:00]

On 2017/01/10 22:50:53, ojan wrote:
> FYI, I'm waiting on our email thread about this to resolve before reviewing
> since it might change what this patch does. I'm not sure at a quick glance why
> the console message is getting truncated.

We've abandoned this approach, right?  Marking the CL closed to get it off my
review radar (but feel free to undo if I'm missing something).

[Bin Lu, 2017-02-27 17:16:37]

On 2017/02/25 15:02:00, Rick Byers wrote:
> On 2017/01/10 22:50:53, ojan wrote:
> > FYI, I'm waiting on our email thread about this to resolve before reviewing
> > since it might change what this patch does. I'm not sure at a quick glance
why
> > the console message is getting truncated.
> 
> We've abandoned this approach, right?  Marking the CL closed to get it off my
> review radar (but feel free to undo if I'm missing something).

Yes, Thanks Rick!