third_party/WebKit/Source/core/frame/Frame.h - Issue 2617313002: Add deprecation message for top navigations from sandbox w/ 'allow-top-navigation' but no gesture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Frame.h

Issue 2617313002: Add deprecation message for top navigations from sandbox w/ 'allow-top-navigation' but no gesture (Closed)

Patch Set: Add the deprecation message to fix the broken tests in LayoutTests/fast/frames/. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/Frame.h

diff --git a/third_party/WebKit/Source/core/frame/Frame.h b/third_party/WebKit/Source/core/frame/Frame.h

index 5f0aec9661d5f574e2c77278ab873dd9aee6c008..d685f8e711fd33043a7797d798a2d49f302833d4 100644

--- a/third_party/WebKit/Source/core/frame/Frame.h

+++ b/third_party/WebKit/Source/core/frame/Frame.h

@@ -126,7 +126,7 @@ class CORE_EXPORT Frame : public GarbageCollectedFinalized<Frame> {

bool canNavigate(const Frame&);

virtual void printNavigationErrorMessage(const Frame&,

const char* reason) = 0;

- virtual void printNavigationWarning(const String&) = 0;

+ virtual void printNavigationWarning(const Frame&, const char* reason) = 0;

// TODO(pilgrim): Replace all instances of ownerLayoutObject() with

// ownerLayoutItem(), https://crbug.com/499321