Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/frame/Frame.h

Issue 2617313002: Add deprecation message for top navigations from sandbox w/ 'allow-top-navigation' but no gesture (Closed)
Patch Set: Add the deprecation message to fix the broken tests in LayoutTests/fast/frames/. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
9 * reserved. 9 * reserved.
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 // This prepares the Frame for the next commit. It will detach children, 119 // This prepares the Frame for the next commit. It will detach children,
120 // dispatch unload events, abort XHR requests and detach the document. 120 // dispatch unload events, abort XHR requests and detach the document.
121 // Returns true if the frame is ready to receive the next commit, or false 121 // Returns true if the frame is ready to receive the next commit, or false
122 // otherwise. 122 // otherwise.
123 virtual bool prepareForCommit() = 0; 123 virtual bool prepareForCommit() = 0;
124 124
125 // TODO(japhet): These should all move to LocalFrame. 125 // TODO(japhet): These should all move to LocalFrame.
126 bool canNavigate(const Frame&); 126 bool canNavigate(const Frame&);
127 virtual void printNavigationErrorMessage(const Frame&, 127 virtual void printNavigationErrorMessage(const Frame&,
128 const char* reason) = 0; 128 const char* reason) = 0;
129 virtual void printNavigationWarning(const String&) = 0; 129 virtual void printNavigationWarning(const Frame&, const char* reason) = 0;
130 130
131 // TODO(pilgrim): Replace all instances of ownerLayoutObject() with 131 // TODO(pilgrim): Replace all instances of ownerLayoutObject() with
132 // ownerLayoutItem(), https://crbug.com/499321 132 // ownerLayoutItem(), https://crbug.com/499321
133 LayoutPart* ownerLayoutObject() 133 LayoutPart* ownerLayoutObject()
134 const; // LayoutObject for the element that contains this frame. 134 const; // LayoutObject for the element that contains this frame.
135 LayoutPartItem ownerLayoutItem() const; 135 LayoutPartItem ownerLayoutItem() const;
136 136
137 Settings* settings() const; // can be null 137 Settings* settings() const; // can be null
138 138
139 // isLoading() is true when the embedder should think a load is in progress. 139 // isLoading() is true when the embedder should think a load is in progress.
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 return m_treeNode; 179 return m_treeNode;
180 } 180 }
181 181
182 // Allow equality comparisons of Frames by reference or pointer, 182 // Allow equality comparisons of Frames by reference or pointer,
183 // interchangeably. 183 // interchangeably.
184 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES(Frame) 184 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES(Frame)
185 185
186 } // namespace blink 186 } // namespace blink
187 187
188 #endif // Frame_h 188 #endif // Frame_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698