third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-WARN-top-navigation-without-user-gesture.html - Issue 2617313002: Add deprecation message for top navigations from sandbox w/ 'allow-top-navigation' but no gesture

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-WARN-top-navigation-without-user-gesture.html

Issue 2617313002: Add deprecation message for top navigations from sandbox w/ 'allow-top-navigation' but no gesture (Closed)

Patch Set: Add the deprecation message to fix the broken tests in LayoutTests/fast/frames/. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script>

	4 if (window.testRunner) {

	5 testRunner.dumpAsText();

	6 testRunner.dumpChildFramesAsText();

	7 testRunner.setDumpConsoleMessages(true);

	8 testRunner.waitUntilDone();

	9 }

	10

	11 if (window.internals)

	12 internals.runtimeFlags.setFramebustingNeedsSameOriginOrUserGesture = true;

	13

	14 window.addEventListener("message", e => {

	15 if (e.data == "PASS")

	16 testRunner.notifyDone();

	17 else

	18 testRunner.testFailed("'top.location' didn't throw.");

	19 });

	20 </script>

	21 </head>

	22 <body>

	23 <iframe sandbox='allow-top-navigation allow-scripts' src="http://localhost:8000/ security/frameNavigation/resources/iframe-that-performs-top-navigation-without-u ser-gesture.html"></iframe>

	24 </body>

	25 </html>

OLD	NEW