Add deprecation message for top navigations from sandbox w/ 'allow-top-navigation' but no gesture

third_party/WebKit/Source/core/frame/LocalFrame.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Simon Hausmann <hausmann@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  *                     2001 George Staikos <staikos@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
@@ skipping 448 matching lines @@
 }
 
 bool LocalFrame::prepareForCommit() {
   return loader().prepareForCommit();
 }
 
 SecurityContext* LocalFrame::securityContext() const {
   return document();
 }
 
+String LocalFrame::getTargetFrameDescription(const Frame& targetFrame) const {
+  // URLs aren't available for RemoteFrames, so the error message uses their
+  // origin instead.
+  return targetFrame.isLocalFrame()
+             ? "with URL '" +
+                   toLocalFrame(targetFrame).document()->url().getString() + "'"
+             : "with origin '" +
+                   targetFrame.securityContext()
+                       ->getSecurityOrigin()
+                       ->toString() +
+                   "'";
+}
+
 void LocalFrame::printNavigationErrorMessage(const Frame& targetFrame,
                                              const char* reason) {
-  // URLs aren't available for RemoteFrames, so the error message uses their
-  // origin instead.
-  String targetFrameDescription =
-      targetFrame.isLocalFrame()
-          ? "with URL '" +
-                toLocalFrame(targetFrame).document()->url().getString() + "'"
-          : "with origin '" +
-                targetFrame.securityContext()->getSecurityOrigin()->toString() +
-                "'";
   String message =
       "Unsafe JavaScript attempt to initiate navigation for frame " +
-      targetFrameDescription + " from frame with URL '" +
+      getTargetFrameDescription(targetFrame) + " from frame with URL '" +
       document()->url().getString() + "'. " + reason + "\n";
 
   domWindow()->printErrorMessage(message);
 }
 
-void LocalFrame::printNavigationWarning(const String& message) {
+void LocalFrame::printNavigationWarning(const Frame& targetFrame,
+                                        const char* reason) {
+  String message = "Frame with URL '" + document()->url().getString() +
+                   "' attempted to navigate its top-level window " +
+                   getTargetFrameDescription(targetFrame) + ". " + reason +
+                   "\n";
   m_console->addMessage(
       ConsoleMessage::create(JSMessageSource, WarningMessageLevel, message));
 }
 
 WindowProxyManager* LocalFrame::getWindowProxyManager() const {
   return m_script->getWindowProxyManager();
 }
 
 bool LocalFrame::shouldClose() {
   // TODO(dcheng): This should be fixed to dispatch beforeunload events to
@@ skipping 440 matching lines @@
   if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext())
     m_frame->client()->frameBlameContext()->Enter();
 }
 
 ScopedFrameBlamer::~ScopedFrameBlamer() {
   if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext())
     m_frame->client()->frameBlameContext()->Leave();
 }
 
 }  // namespace blink