third_party/WebKit/Source/core/frame/LocalFrame.h - Issue 2617313002: Add deprecation message for top navigations from sandbox w/ 'allow-top-navigation' but no gesture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2617313002: Add deprecation message for top navigations from sandbox w/ 'allow-top-navigation' but no gesture (Closed)

Patch Set: Add the deprecation message to fix the broken tests in LayoutTests/fast/frames/. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalFrame.h

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h

index da62177aeabab49db8943344be18308a28f0f0c6..fe396c70e4c06bf6c23524f6d4a9e990356f9ac0 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.h

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h

@@ -117,8 +117,9 @@ class CORE_EXPORT LocalFrame final : public Frame,

void detach(FrameDetachType) override;

bool shouldClose() override;

SecurityContext* securityContext() const override;

+ String getTargetFrameDescription(const Frame& targetFrame) const;

void printNavigationErrorMessage(const Frame&, const char* reason) override;

- void printNavigationWarning(const String&) override;

+ void printNavigationWarning(const Frame&, const char* reason) override;

bool prepareForCommit() override;

void didChangeVisibilityState() override;

void setDocumentHasReceivedUserGesture() override;