Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2612903007: Migrate WTF::Vector::append() to ::push_back() [part 15 of N] (Closed)

Created:
3 years, 11 months ago by pilgrim_google
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews, cmumford, dcheng, gavinp+prerender_chromium.org, jsbell+idb_chromium.org, kinuko+watch, kinuko+fileapi, mlamouri+watch-blink_chromium.org, nhiroki, tzik, Yoav Weiss, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Vector::append() to ::push_back() [part 15 of N] As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. This CL replaces append() with push_back() in Source/web/. There are too many references to change them all at once, so this CL is part 15 of many. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2612903007 Cr-Commit-Position: refs/heads/master@{#441830} Committed: https://chromium.googlesource.com/chromium/src/+/c41acedb493c6d405f2f9bb665e6d366e33a45dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -72 lines) Patch
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/CompositionUnderlineVectorBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/DateTimeChooserImpl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/TextFinder.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebDOMActivityLogger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFileChooserCompletionImpl.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFormElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebHistoryItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebIDBKey.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSearchableFormData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebTextCheckingCompletionImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebTextCheckingResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/MHTMLTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/PrerenderingTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/RootScrollerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ViewportTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 14 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
pilgrim_google
3 years, 11 months ago (2017-01-05 21:52:35 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-05 23:10:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612903007/1
3 years, 11 months ago (2017-01-06 02:17:47 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 02:25:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c41acedb493c6d405f2f9bb665e6...

Powered by Google App Engine
This is Rietveld 408576698