third_party/WebKit/Source/web/WebHistoryItem.cpp - Issue 2612903007: Migrate WTF::Vector::append() to ::push_back() [part 15 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebHistoryItem.cpp

Issue 2612903007: Migrate WTF::Vector::append() to ::push_back() [part 15 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebHistoryItem.cpp

diff --git a/third_party/WebKit/Source/web/WebHistoryItem.cpp b/third_party/WebKit/Source/web/WebHistoryItem.cpp

index 08fafabb19576981b886782a93a9ac8e7c8b5fad..689741728f813c7b54d0b2d84bda78ab97d7a642 100644

--- a/third_party/WebKit/Source/web/WebHistoryItem.cpp

+++ b/third_party/WebKit/Source/web/WebHistoryItem.cpp

@@ -121,7 +121,7 @@ void WebHistoryItem::setDocumentState(const WebVector<WebString>& state) {

// FIXME: would be nice to avoid the intermediate copy

Vector<String> ds;

for (size_t i = 0; i < state.size(); ++i)

- ds.append(state[i]);

+ ds.push_back(state[i]);

m_private->setDocumentState(ds);

}