third_party/WebKit/Source/web/ExternalPopupMenu.cpp - Issue 2612903007: Migrate WTF::Vector::append() to ::push_back() [part 15 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenu.cpp

Issue 2612903007: Migrate WTF::Vector::append() to ::push_back() [part 15 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ExternalPopupMenu.cpp

diff --git a/third_party/WebKit/Source/web/ExternalPopupMenu.cpp b/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

index 2fe19c3672dc57d4f9bfc46075ea5a1333653e50..98c74fa21dd2891684d670023a8e8cc103d71b77 100644

--- a/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

+++ b/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

@@ -214,7 +214,7 @@ void ExternalPopupMenu::didAcceptIndices(const WebVector<int>& indices) {

Vector<int> listIndices;

listIndices.reserveCapacity(indices.size());

for (size_t i = 0; i < indices.size(); ++i)

- listIndices.append(toPopupMenuItemIndex(indices[i], *ownerElement));

+ listIndices.push_back(toPopupMenuItemIndex(indices[i], *ownerElement));

ownerElement->selectMultipleOptionsByPopup(listIndices);

}