third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp - Issue 2612903007: Migrate WTF::Vector::append() to ::push_back() [part 15 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

Issue 2612903007: Migrate WTF::Vector::append() to ::push_back() [part 15 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

diff --git a/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp b/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

index 976daabfefb769e29baaebffeb6f0887cd3351ad..8df6c6232d52fffb913ed93ae5c36f1c3844afb9 100644

--- a/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

+++ b/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

@@ -89,7 +89,7 @@ void ColorChooserPopupUIController::writeDocument(SharedBuffer* data) {

Vector<ColorSuggestion> suggestions = m_client->suggestions();

Vector<String> suggestionValues;

for (unsigned i = 0; i < suggestions.size(); i++)

- suggestionValues.append(suggestions[i].color.serialized());

+ suggestionValues.push_back(suggestions[i].color.serialized());

IntRect anchorRectInScreen = m_chromeClient->viewportToScreen(

m_client->elementRectRelativeToViewport(), m_frame->view());