Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp

Issue 2612903007: Migrate WTF::Vector::append() to ::push_back() [part 15 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp b/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
index e74dd129b56fcf329960b53849826b6b26c1a262..d25a991b87deeb0bad7155740d94911da4ab21c7 100644
--- a/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
+++ b/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
@@ -25,13 +25,13 @@ class TestActivityLogger : public V8DOMActivityLogger {
~TestActivityLogger() override {}
void logGetter(const String& apiName) override {
- m_loggedActivities.append(apiName);
+ m_loggedActivities.push_back(apiName);
}
void logSetter(const String& apiName,
const v8::Local<v8::Value>& newValue) override {
- m_loggedActivities.append(apiName + " | " +
- toCoreStringWithUndefinedOrNullCheck(newValue));
+ m_loggedActivities.push_back(
+ apiName + " | " + toCoreStringWithUndefinedOrNullCheck(newValue));
}
void logMethod(const String& apiName,
@@ -41,7 +41,7 @@ class TestActivityLogger : public V8DOMActivityLogger {
for (int i = 0; i < argc; i++)
activityString = activityString + " | " +
toCoreStringWithUndefinedOrNullCheck(argv[i]);
- m_loggedActivities.append(activityString);
+ m_loggedActivities.push_back(activityString);
}
void logEvent(const String& eventName,
@@ -51,7 +51,7 @@ class TestActivityLogger : public V8DOMActivityLogger {
for (int i = 0; i < argc; i++) {
activityString = activityString + " | " + argv[i];
}
- m_loggedActivities.append(activityString);
+ m_loggedActivities.push_back(activityString);
}
void clear() { m_loggedActivities.clear(); }
@@ -93,7 +93,7 @@ class ActivityLoggerTest : public testing::Test {
void executeScriptInIsolatedWorld(const String& script) const {
v8::HandleScope scope(v8::Isolate::GetCurrent());
HeapVector<ScriptSourceCode> sources;
- sources.append(ScriptSourceCode(script));
+ sources.push_back(ScriptSourceCode(script));
Vector<v8::Local<v8::Value>> results;
m_scriptController->executeScriptInIsolatedWorld(isolatedWorldId, sources,
extensionGroup, 0);
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698