Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2611453002: Remove ScopedVector from autofill::FormStructure (Closed)

Created:
3 years, 11 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 11 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jam, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from autofill::FormStructure BUG=554289

Patch Set 1 #

Patch Set 2 : Fix ios build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -94 lines) Patch
M chrome/browser/autofill/form_structure_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_download_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/core/browser/form_field.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/form_field.cc View 2 chunks +12 lines, -16 lines 0 comments Download
M components/autofill/core/browser/form_field_unittest.cc View 3 chunks +15 lines, -11 lines 0 comments Download
M components/autofill/core/browser/form_structure.h View 4 chunks +6 lines, -6 lines 0 comments Download
M components/autofill/core/browser/form_structure.cc View 21 chunks +26 lines, -24 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/browser_save_password_progress_logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/password_generation_manager.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M ios/chrome/browser/autofill/autofill_agent.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autofill/autofill_controller_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autofill/form_structure_browsertest.mm View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (9 generated)
leonhsl(Using Gerrit)
Hi, Vaclav, would you PTAL? Thanks.
3 years, 11 months ago (2017-01-01 12:12:18 UTC) #10
vabr (Chromium)
Thanks and LGTM! However, please be aware that your CL overlaps and possibly conflicts with ...
3 years, 11 months ago (2017-01-02 08:21:02 UTC) #11
leonhsl(Using Gerrit)
3 years, 11 months ago (2017-01-02 12:36:56 UTC) #12 
On 2017/01/02 08:21:02, vabr (mostly OOO until Feb) wrote:
> Thanks and LGTM!
> However, please be aware that your CL overlaps and possibly conflicts with
> https://codereview.chromium.org/2609703002/ which I am going to review now.
> 
> Cheers,
> Vaclav

Aha, we have duplicated work for autofill :) And I noticed that CL has included
this CL's work, and is doing more than this CL, I'd like to close this one now.
Thanks a lot for review!

Powered by Google App Engine
This is Rietveld 408576698