Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: components/password_manager/core/browser/password_generation_manager.cc

Issue 2611453002: Remove ScopedVector from autofill::FormStructure (Closed)
Patch Set: Fix ios build Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_generation_manager.cc
diff --git a/components/password_manager/core/browser/password_generation_manager.cc b/components/password_manager/core/browser/password_generation_manager.cc
index d33425534a6f30af8970c21831b58d98d3ea0f40..59c4d246ccc1ae6d3e8baa456e58d35f801eba50 100644
--- a/components/password_manager/core/browser/password_generation_manager.cc
+++ b/components/password_manager/core/browser/password_generation_manager.cc
@@ -30,14 +30,8 @@ void PasswordGenerationManager::DetectFormsEligibleForGeneration(
std::vector<autofill::PasswordFormGenerationData>
forms_eligible_for_generation;
- for (std::vector<autofill::FormStructure*>::const_iterator form_it =
- forms.begin();
- form_it != forms.end(); ++form_it) {
- autofill::FormStructure* form = *form_it;
- for (std::vector<autofill::AutofillField*>::const_iterator field_it =
- form->begin();
- field_it != form->end(); ++field_it) {
- autofill::AutofillField* field = *field_it;
+ for (const autofill::FormStructure* form : forms) {
+ for (const auto& field : *form) {
if (field->server_type() == autofill::ACCOUNT_CREATION_PASSWORD ||
field->server_type() == autofill::NEW_PASSWORD) {
forms_eligible_for_generation.push_back(

Powered by Google App Engine
This is Rietveld 408576698