Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: components/autofill/core/browser/personal_data_manager.cc

Issue 2611453002: Remove ScopedVector from autofill::FormStructure (Closed)
Patch Set: Fix ios build Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/personal_data_manager.cc
diff --git a/components/autofill/core/browser/personal_data_manager.cc b/components/autofill/core/browser/personal_data_manager.cc
index b58bc6cdea9578efe5813cd47a7e7ff28eacd533..f8f6c587f5da89eebaff4748f91934b2079d60d2 100644
--- a/components/autofill/core/browser/personal_data_manager.cc
+++ b/components/autofill/core/browser/personal_data_manager.cc
@@ -1373,7 +1373,7 @@ bool PersonalDataManager::ImportAddressProfiles(const FormStructure& form) {
// Relevant sections for address fields.
std::set<std::string> sections;
- for (const AutofillField* field : form) {
+ for (const auto& field : form) {
if (field->Type().group() != CREDIT_CARD)
sections.insert(field->section());
}
@@ -1410,7 +1410,7 @@ bool PersonalDataManager::ImportAddressProfileForSection(
std::set<ServerFieldType> types_seen;
// Go through each |form| field and attempt to constitute a valid profile.
- for (const AutofillField* field : form) {
+ for (const auto& field : form) {
// Reject fields that are not within the specified |section|.
if (field->section() != section)
continue;
@@ -1490,7 +1490,7 @@ bool PersonalDataManager::ImportCreditCard(
candidate_credit_card.set_origin(form.source_url().spec());
std::set<ServerFieldType> types_seen;
- for (const AutofillField* field : form) {
+ for (const auto& field : form) {
base::string16 value;
base::TrimWhitespace(field->value, base::TRIM_ALL, &value);

Powered by Google App Engine
This is Rietveld 408576698