Remove ScopedVector from autofill.

Remove ScopedVector from autofill.

BUG=554289
Committed: https://crrev.com/68dd9fba0f5faed2f28faeecbfd2b1ce6cc2d14d
Cr-Commit-Position: refs/heads/master@{#441134}

[Avi (use Gerrit), 2016-12-31 20:37:45]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-31 20:37:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-31 20:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-31 20:46:06]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Avi (use Gerrit), 2016-12-31 21:34:11]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-31 21:34:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-12-31 22:34:54]

avi@chromium.org changed reviewers:
+ mathp@chromium.org, vabr@google.com

[Avi (use Gerrit), 2016-12-31 22:34:55]

To any reviewer in the office.

[commit-bot: I haz the power, 2016-12-31 22:36:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-31 22:36:37]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-01-01 16:07:44]

avi@chromium.org changed reviewers:
+ vabr@chromium.org
- vabr@google.com

[vabr (Chromium), 2017-01-02 08:30:21]

Thanks and LGTM!

Please be aware of an overlapping/conflicting
https://codereview.chromium.org/2611453002/.

Cheers,
Vaclav

https://codereview.chromium.org/2609703002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/form_structure.h (right):

https://codereview.chromium.org/2609703002/diff/20001/components/autofill/cor...
components/autofill/core/browser/form_structure.h:49: using FieldsVector =
std::vector<std::unique_ptr<AutofillField>>;
nit: I'm not completely sure if this alias is helpful. While shorter, it does
not convey the ownership. Would it be a big pain to just inline the long type
instead?

[Avi (use Gerrit), 2017-01-02 20:30:19]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2017-01-02 20:30:20]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2609703002/#ps40001
(title: "drop the using")

[commit-bot: I haz the power, 2017-01-02 20:30:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-01-02 20:32:03]

https://codereview.chromium.org/2609703002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/form_structure.h (right):

https://codereview.chromium.org/2609703002/diff/20001/components/autofill/cor...
components/autofill/core/browser/form_structure.h:49: using FieldsVector =
std::vector<std::unique_ptr<AutofillField>>;
On 2017/01/02 08:30:21, vabr (mostly OOO until Feb) wrote:
> nit: I'm not completely sure if this alias is helpful. While shorter, it does
> not convey the ownership. Would it be a big pain to just inline the long type
> instead?

Done.

[commit-bot: I haz the power, 2017-01-02 20:36:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-02 20:36:14]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Avi (use Gerrit), 2017-01-02 20:52:36]

avi@chromium.org changed reviewers:
+ bondd@chromium.org, droger@chromium.org, marq@chromium.org,
rohitrao@chromium.org

[Avi (use Gerrit), 2017-01-02 20:52:36]

To any iOS owner in the house.

[rohitrao (ping after 24h), 2017-01-03 14:02:39]

ios/ LGTM

[Avi (use Gerrit), 2017-01-03 16:32:34]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-01-03 16:32:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 16:38:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483461154280520,
"parent_rev": "d622b7e260ccab1af5590724c6bb96dff33e8d2e", "commit_rev":
"b1510ce0d9354852519a3d2bf358c2ff94948270"}

[commit-bot: I haz the power, 2017-01-03 16:38:41]

Description was changed from

==========
Remove ScopedVector from autofill.

BUG=554289
==========

to

==========
Remove ScopedVector from autofill.

BUG=554289

Review-Url: https://codereview.chromium.org/2609703002
==========

[commit-bot: I haz the power, 2017-01-03 16:38:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-03 16:40:47]

Description was changed from

==========
Remove ScopedVector from autofill.

BUG=554289

Review-Url: https://codereview.chromium.org/2609703002
==========

to

==========
Remove ScopedVector from autofill.

BUG=554289

Committed: https://crrev.com/68dd9fba0f5faed2f28faeecbfd2b1ce6cc2d14d
Cr-Commit-Position: refs/heads/master@{#441134}
==========

[commit-bot: I haz the power, 2017-01-03 16:40:48]

Patchset 3 (id:??) landed as
https://crrev.com/68dd9fba0f5faed2f28faeecbfd2b1ce6cc2d14d
Cr-Commit-Position: refs/heads/master@{#441134}