components/password_manager/core/browser/browser_save_password_progress_logger.cc - Issue 2611453002: Remove ScopedVector from autofill::FormStructure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/browser_save_password_progress_logger.cc

Issue 2611453002: Remove ScopedVector from autofill::FormStructure (Closed)

Patch Set: Fix ios build Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/personal_data_manager.cc ('k') | components/password_manager/core/browser/password_form_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/browser_save_password_progress_logger.cc

diff --git a/components/password_manager/core/browser/browser_save_password_progress_logger.cc b/components/password_manager/core/browser/browser_save_password_progress_logger.cc

index 0bd7581812791f9a915d4e0bd8fb9207802dce00..b0968c6978a6b836e6500cdee3c60cd6954c8cb7 100644

--- a/components/password_manager/core/browser/browser_save_password_progress_logger.cc

+++ b/components/password_manager/core/browser/browser_save_password_progress_logger.cc

@@ -114,7 +114,7 @@ std::string BrowserSavePasswordProgressLogger::FormStructureToFieldsLogString(

const autofill::FormStructure& form_structure) {

std::string result;

result += GetStringFromID(STRING_FIELDS) + ": " + "\n";

- for (const autofill::AutofillField* field : form_structure) {

+ for (const auto& field : form_structure) {

std::string field_info = ScrubElementID(field->name) + ": " +

ScrubNonDigit(field->FieldSignatureAsStr()) +

", " + ScrubElementID(field->form_control_type);