Remove ScopedVector from autofill::FormStructure

components/autofill/core/browser/personal_data_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <list>
@@ skipping 1355 matching lines @@
   }
   NotifyPersonalDataChanged();
 }
 
 bool PersonalDataManager::ImportAddressProfiles(const FormStructure& form) {
   if (!form.field_count())
     return false;
 
   // Relevant sections for address fields.
   std::set<std::string> sections;
-  for (const AutofillField* field : form) {
+  for (const auto& field : form) {
     if (field->Type().group() != CREDIT_CARD)
       sections.insert(field->section());
   }
 
   // We save a maximum of 2 profiles per submitted form (e.g. for shipping and
   // billing).
   static const size_t kMaxNumAddressProfilesSaved = 2;
   size_t num_saved_profiles = 0;
   for (const std::string& section : sections) {
     if (num_saved_profiles == kMaxNumAddressProfilesSaved)
@@ skipping 16 matching lines @@
 
   // We only set complete phone, so aggregate phone parts in these vars and set
   // complete at the end.
   PhoneNumber::PhoneCombineHelper combined_phone;
 
   // Used to detect and discard address forms with multiple fields of the same
   // type.
   std::set<ServerFieldType> types_seen;
 
   // Go through each |form| field and attempt to constitute a valid profile.
-  for (const AutofillField* field : form) {
+  for (const auto& field : form) {
     // Reject fields that are not within the specified |section|.
     if (field->section() != section)
       continue;
 
     base::string16 value;
     base::TrimWhitespace(field->value, base::TRIM_ALL, &value);
 
     // If we don't know the type of the field, or the user hasn't entered any
     // information into the field, or the field is non-focusable (hidden), then
     // skip it.
@@ skipping 59 matching lines @@
     bool should_return_local_card,
     std::unique_ptr<CreditCard>* imported_credit_card) {
   DCHECK(!imported_credit_card->get());
 
   // The candidate for credit card import. There are many ways for the candidate
   // to be rejected (see everywhere this function returns false, below).
   CreditCard candidate_credit_card;
   candidate_credit_card.set_origin(form.source_url().spec());
 
   std::set<ServerFieldType> types_seen;
-  for (const AutofillField* field : form) {
+  for (const auto& field : form) {
     base::string16 value;
     base::TrimWhitespace(field->value, base::TRIM_ALL, &value);
 
     // If we don't know the type of the field, or the user hasn't entered any
     // information into the field, or the field is non-focusable (hidden), then
     // skip it.
     if (!field->IsFieldFillable() || !field->is_focusable || value.empty())
       continue;
 
     AutofillType field_type = field->Type();
@@ skipping 349 matching lines @@
     }
 
     // If the card was modified, apply the changes to the database.
     if (was_modified) {
       database_->UpdateCreditCard(*credit_card);
     }
   }
 }
 
 }  // namespace autofill