Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2610863002: Fix deps in all BUILD.gn files in ios. (Closed)

Created:
3 years, 11 months ago by sdefresne
Modified:
3 years, 11 months ago
Reviewers:
lpromero
CC:
chromium-reviews, msramek+watch_chromium.org, browser-components-watch_chromium.org, noyau+watch_chromium.org, markusheintz_, jdonnelly+watch_chromium.org, cbentzel+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, sebsg+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, gogerald+paymentswatch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, extensions-reviews_chromium.org, rouslan+autofill_chromium.org, rouslan+payments_chromium.org, asvitkine+watch_chromium.org, Michael van Ouwerkerk, gcasto+watchlist_chromium.org, sdefresne+watch_chromium.org, mathp+autofillwatch_chromium.org, tfarina, pkl (ping after 24h if needed), estade+watch_chromium.org, stkhapugin, sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix deps in all BUILD.gn files in ios. Automatically created by invoking the fix_deps.py script (attached to the bug referenced below) on ios. BUG=678528 Committed: https://crrev.com/037962fc95598422fd3af2626bff10450543c62e Cr-Commit-Position: refs/heads/master@{#441613}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -113 lines) Patch
M ios/chrome/app/BUILD.gn View 5 chunks +5 lines, -5 lines 0 comments Download
M ios/chrome/app/application_delegate/BUILD.gn View 2 chunks +1 line, -2 lines 1 comment Download
M ios/chrome/app/safe_mode/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/autofill/BUILD.gn View 5 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/browsing_data/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/crash_report/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/device_sharing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/geolocation/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/metrics/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/native_app_launcher/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/passwords/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/payments/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/snapshots/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/translate/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/BUILD.gn View 4 chunks +4 lines, -5 lines 1 comment Download
M ios/chrome/browser/ui/activity_services/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/alert_coordinator/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/authentication/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/bookmarks/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/contextual_search/BUILD.gn View 4 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/dialogs/BUILD.gn View 5 chunks +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/downloads/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/find_bar/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/first_run/BUILD.gn View 4 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/history/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/icons/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/infobars/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/ntp/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/overscroll_actions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/popup_menu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/qr_scanner/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/settings/BUILD.gn View 4 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/side_swipe/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/stack_view/BUILD.gn View 5 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/tabs/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/BUILD.gn View 4 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/web/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/share_extension/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/test/app/BUILD.gn View 1 chunk +7 lines, -7 lines 0 comments Download
M ios/chrome/test/earl_grey/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/today_extension/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ios/crnet/BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
M ios/public/provider/chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/public/provider/chrome/browser/distribution/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/public/provider/chrome/browser/images/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/public/provider/chrome/browser/omaha/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/public/provider/chrome/browser/signin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/public/provider/chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/public/provider/chrome/browser/user_feedback/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M ios/web/shell/test/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
sdefresne
Please take a look. https://codereview.chromium.org/2610863002/diff/1/ios/chrome/app/application_delegate/BUILD.gn File ios/chrome/app/application_delegate/BUILD.gn (left): https://codereview.chromium.org/2610863002/diff/1/ios/chrome/app/application_delegate/BUILD.gn#oldcode41 ios/chrome/app/application_delegate/BUILD.gn:41: "//ios/chrome/app/application_delegate", This is a duplicated ...
3 years, 11 months ago (2017-01-04 15:30:00 UTC) #4
lpromero
lgtm Is there any value in you sharing the script (even just in a pastebin) ...
3 years, 11 months ago (2017-01-04 16:51:46 UTC) #8
sdefresne
On 2017/01/04 16:51:46, lpromero wrote: > lgtm > > Is there any value in you ...
3 years, 11 months ago (2017-01-05 08:46:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610863002/1
3 years, 11 months ago (2017-01-05 08:46:56 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-05 08:52:14 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 08:53:59 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/037962fc95598422fd3af2626bff10450543c62e
Cr-Commit-Position: refs/heads/master@{#441613}

Powered by Google App Engine
This is Rietveld 408576698