Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: ios/chrome/app/application_delegate/BUILD.gn

Issue 2610863002: Fix deps in all BUILD.gn files in ios. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/app/application_delegate/BUILD.gn
diff --git a/ios/chrome/app/application_delegate/BUILD.gn b/ios/chrome/app/application_delegate/BUILD.gn
index c56736b78e39c150af8b54ea8aef51b4933c6287..c29ebfcbbfd9eb2e4dc99b727c3a77e2ac9625b9 100644
--- a/ios/chrome/app/application_delegate/BUILD.gn
+++ b/ios/chrome/app/application_delegate/BUILD.gn
@@ -38,7 +38,6 @@ source_set("unit_tests") {
"//components/metrics",
"//ios/chrome/app",
"//ios/chrome/app:app_internal",
- "//ios/chrome/app/application_delegate",
sdefresne 2017/01/04 15:29:59 This is a duplicated dependency as this target alr
"//ios/chrome/app/safe_mode",
"//ios/chrome/app/spotlight",
"//ios/chrome/browser",
@@ -92,13 +91,13 @@ source_set("application_delegate_internal") {
"user_activity_handler.mm",
]
deps = [
+ ":application_delegate",
"//base",
"//components/crash/core/common",
"//components/handoff",
"//components/metrics",
"//components/prefs",
"//ios/chrome/app",
- "//ios/chrome/app/application_delegate",
"//ios/chrome/app/safe_mode",
"//ios/chrome/app/spotlight",
"//ios/chrome/browser",

Powered by Google App Engine
This is Rietveld 408576698