Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: ios/chrome/browser/ui/BUILD.gn

Issue 2610863002: Fix deps in all BUILD.gn files in ios. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/BUILD.gn
diff --git a/ios/chrome/browser/ui/BUILD.gn b/ios/chrome/browser/ui/BUILD.gn
index 90523244a6c4ce5bba5099dbb94b3961669e497a..83ee9d9539036c7fdd815c25a74623b774bc2702 100644
--- a/ios/chrome/browser/ui/BUILD.gn
+++ b/ios/chrome/browser/ui/BUILD.gn
@@ -115,7 +115,6 @@ source_set("unit_tests") {
"//ios/chrome/browser/search_engines",
"//ios/chrome/browser/sessions",
"//ios/chrome/browser/tabs",
- "//ios/chrome/browser/ui",
sdefresne 2017/01/04 15:29:59 This is a duplicate dependency as the target alrea
"//ios/chrome/browser/ui/activity_services",
"//ios/chrome/browser/ui/alert_coordinator",
"//ios/chrome/browser/ui/commands",
@@ -250,6 +249,8 @@ source_set("ui_internal") {
]
deps = [
":browser_list",
+ ":resources",
+ ":ui",
"//base",
"//base:i18n",
"//components/bookmarks/browser",
@@ -284,8 +285,6 @@ source_set("ui_internal") {
"//ios/chrome/browser/snapshots",
"//ios/chrome/browser/snapshots:snapshots_internal",
"//ios/chrome/browser/tabs",
- "//ios/chrome/browser/ui",
- "//ios/chrome/browser/ui:resources",
"//ios/chrome/browser/ui/activity_services",
"//ios/chrome/browser/ui/alert_coordinator",
"//ios/chrome/browser/ui/authentication",
@@ -405,11 +404,11 @@ source_set("eg_tests") {
"keyboard_commands_egtest.mm",
]
deps = [
+ ":ui",
+ ":ui_internal",
"//base",
"//components/strings",
"//ios/chrome/app/strings",
- "//ios/chrome/browser/ui",
- "//ios/chrome/browser/ui:ui_internal",
"//ios/chrome/browser/ui/commands",
"//ios/chrome/browser/ui/ntp:ntp_internal",
"//ios/chrome/browser/ui/toolbar",

Powered by Google App Engine
This is Rietveld 408576698