Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: ios/chrome/browser/ui/ntp/BUILD.gn

Issue 2610863002: Fix deps in all BUILD.gn files in ios. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/ntp/BUILD.gn
diff --git a/ios/chrome/browser/ui/ntp/BUILD.gn b/ios/chrome/browser/ui/ntp/BUILD.gn
index 8e94b3b98d66d679824dabbfa1255c96d87c00d3..b5b979e83bd6c7c2c1c326f742a1aa2be702d5dd 100644
--- a/ios/chrome/browser/ui/ntp/BUILD.gn
+++ b/ios/chrome/browser/ui/ntp/BUILD.gn
@@ -142,6 +142,7 @@ source_set("ntp_internal") {
]
deps = [
":ntp",
+ ":resources",
"//base",
"//base:i18n",
"//components/favicon/core",
@@ -176,7 +177,6 @@ source_set("ntp_internal") {
"//ios/chrome/browser/ui/bookmarks",
"//ios/chrome/browser/ui/commands",
"//ios/chrome/browser/ui/context_menu",
- "//ios/chrome/browser/ui/ntp:resources",
"//ios/chrome/browser/ui/ntp/recent_tabs",
"//ios/chrome/browser/ui/overscroll_actions",
"//ios/chrome/browser/ui/toolbar",
@@ -247,11 +247,11 @@ source_set("eg_tests") {
"new_tab_page_egtest.mm",
]
deps = [
+ ":ntp_internal",
"//components/strings",
"//ios/chrome/app/strings",
"//ios/chrome/browser/ui",
"//ios/chrome/browser/ui/commands",
- "//ios/chrome/browser/ui/ntp:ntp_internal",
"//ios/chrome/test/app:test_support",
"//ios/chrome/test/earl_grey:test_support",
"//ios/testing:ios_test_support",

Powered by Google App Engine
This is Rietveld 408576698