Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: ios/chrome/browser/metrics/BUILD.gn

Issue 2610863002: Fix deps in all BUILD.gn files in ios. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/metrics/BUILD.gn
diff --git a/ios/chrome/browser/metrics/BUILD.gn b/ios/chrome/browser/metrics/BUILD.gn
index 3232e1fb3ab12a793dae4b3798b34a05a56ec94d..cfccc2cd6fed671e997b9b4544f457f718bc8328 100644
--- a/ios/chrome/browser/metrics/BUILD.gn
+++ b/ios/chrome/browser/metrics/BUILD.gn
@@ -94,16 +94,16 @@ source_set("metrics_internal") {
"tab_usage_recorder_delegate.h",
]
deps = [
+ ":metrics",
"//base",
"//components/google/core/browser",
"//ios/chrome/browser",
"//ios/chrome/browser/browser_state",
- "//ios/chrome/browser/metrics",
"//ios/chrome/browser/tabs",
"//ios/chrome/browser/ui",
"//ios/chrome/browser/ui:browser_list",
"//ios/web",
- "//ui/base:base",
+ "//ui/base",
"//url",
]
libs = [ "UIKit.framework" ]
@@ -117,10 +117,10 @@ source_set("unit_tests_internal") {
"tab_usage_recorder_unittest.mm",
]
deps = [
+ ":metrics",
":metrics_internal",
"//base",
"//base/test:test_support",
- "//ios/chrome/browser/metrics",
"//ios/chrome/browser/tabs",
"//ios/chrome/browser/ui",
"//ios/testing:ocmock_support",
@@ -137,12 +137,12 @@ source_set("eg_tests") {
"tab_usage_recorder_egtest.mm",
]
deps = [
+ ":metrics_internal",
"//base",
"//base/test:test_support",
"//components/strings",
"//ios/chrome/app/strings",
"//ios/chrome/browser",
- "//ios/chrome/browser/metrics:metrics_internal",
"//ios/chrome/browser/ui",
"//ios/chrome/browser/ui/settings",
"//ios/chrome/browser/ui/toolbar",

Powered by Google App Engine
This is Rietveld 408576698