Fix the bug for VertexAttrib{I}Pointer when no array buffer bound

Fix the bug for VertexAttrib{I}Pointer when no array buffer bound

BUG=678850
TEST=conformance/more/functions/vertexAttribPointerBadArgs.html,
     conformance/attribs/gl-vertexattribpointer.html,
     conformance2/attribs/gl-vertexattribipointer.html.
     
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

[yunchao, 2017-01-06 09:59:22]

Description was changed from

==========
Fix the bug for VertexAttrib{I}Pointer when no array buffer bound

BUG=678850
==========

to

==========
Fix the bug for VertexAttrib{I}Pointer when no array buffer bound

BUG=678850
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2017-01-09 16:28:29]

Description was changed from

==========
Fix the bug for VertexAttrib{I}Pointer when no array buffer bound

BUG=678850
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix the bug for VertexAttrib{I}Pointer when no array buffer bound

BUG=678850
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2017-01-09 16:28:29]

yunchao.he@intel.com changed reviewers:
+ kbr@chromium.org, qiankun.miao@intel.com, zmo@chromium.org

[yunchao, 2017-01-09 16:36:26]

PTAL. 

The failures are fixed on my local machine. After
https://codereview.chromium.org/2614313002/ is landed. We can run against all
bots.

[yunchao, 2017-01-09 16:38:57]

Description was changed from

==========
Fix the bug for VertexAttrib{I}Pointer when no array buffer bound

BUG=678850
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix the bug for VertexAttrib{I}Pointer when no array buffer bound

BUG=678850
TEST=conformance/more/functions/vertexAttribPointerBadArgs.html,
     conformance/attribs/gl-vertexattribpointer.html,
     conformance2/attribs/gl-vertexattribipointer.html.
     
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2017-01-09 18:21:15]

looks good in general

https://codereview.chromium.org/2610393003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2610393003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:10912: if (offset != 0) {
I think you can combine this and the else to a simple (offset != 0) condition,
and the error message can just be "offset != 0".

https://codereview.chromium.org/2610393003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:11008: if (offset != 0) {
Same here.

[yunchao, 2017-01-10 14:10:11]

Thanks for your review, Zhenyao. Code has been updated. PTAL.

https://codereview.chromium.org/2610393003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2610393003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:10912: if (offset != 0) {
On 2017/01/09 18:21:15, Zhenyao Mo wrote:
> I think you can combine this and the else to a simple (offset != 0) condition,
> and the error message can just be "offset != 0".

Done.

https://codereview.chromium.org/2610393003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:11008: if (offset != 0) {
On 2017/01/09 18:21:15, Zhenyao Mo wrote:
> Same here.

Done.

[Zhenyao Mo, 2017-01-10 17:12:17]

lgtm

[yunchao, 2017-01-12 00:13:01]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 00:14:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:11:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 02:11:12]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[yunchao, 2017-01-12 07:34:52]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 07:35:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 09:31:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 09:31:01]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yunchao, 2017-01-12 13:09:54]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 13:10:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 13:55:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 13:55:22]

Dry run: This issue passed the CQ dry run.

[yunchao, 2017-01-12 13:56:24]

On 2017/01/10 17:12:17, Zhenyao Mo wrote:
> lgtm

Thanks for your reivew, Zhenyao. Merging now...

[yunchao, 2017-01-12 13:56:33]

The CQ bit was checked by yunchao.he@intel.com

[yunchao, 2017-01-12 13:56:33]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2610393003/#ps60001
(title: "suppress webgl cts expectation for passthrough cmd buffer")

[commit-bot: I haz the power, 2017-01-12 13:56:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 14:01:39]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484229393142360,
"parent_rev": "f651acf25aaea54d6aed2488c8237214f1a2b38f", "commit_rev":
"314c0c8fcb9c97c7588a2302df4df7b4b0097c0c"}

[commit-bot: I haz the power, 2017-01-12 14:05:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 14:05:46]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[yunchao, 2017-01-12 15:53:52]

On 2017/01/12 14:05:46, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

This change has been merged. Close it now.