third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp - Issue 2610393003: Fix the bug for VertexAttrib{I}Pointer when no array buffer bound

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 2610393003: Fix the bug for VertexAttrib{I}Pointer when no array buffer bound (Closed)

Patch Set: suppress webgl cts expectation for passthrough cmd buffer Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

index 3f07acb60c3703e52bc1ff9a640f0bb648afe07a..be8a78cdc7d435f36cd71518609d7b97b70114b0 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

@@ -2439,9 +2439,9 @@ void WebGL2RenderingContextBase::vertexAttribIPointer(GLuint index,

}

if (!validateValueFitNonNegInt32("vertexAttribIPointer", "offset", offset))

return;

- if (!m_boundArrayBuffer) {

+ if (!m_boundArrayBuffer && offset != 0) {

synthesizeGLError(GL_INVALID_OPERATION, "vertexAttribIPointer",

- "no bound ARRAY_BUFFER");

+ "no ARRAY_BUFFER is bound and offset is non-zero");

return;

}