Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2610393003: Fix the bug for VertexAttrib{I}Pointer when no array buffer bound (Closed)
Patch Set: suppress webgl cts expectation for passthrough cmd buffer Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
index 548737c8af2f6d93b4b25d97ade7737c882df962..56c3ab8b0313c426fc6d9ea0da25a3c5c8811294 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
@@ -6126,9 +6126,9 @@ void WebGLRenderingContextBase::vertexAttribPointer(GLuint index,
}
if (!validateValueFitNonNegInt32("vertexAttribPointer", "offset", offset))
return;
- if (!m_boundArrayBuffer) {
+ if (!m_boundArrayBuffer && offset != 0) {
synthesizeGLError(GL_INVALID_OPERATION, "vertexAttribPointer",
- "no bound ARRAY_BUFFER");
+ "no ARRAY_BUFFER is bound and offset is non-zero");
return;
}
« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698