Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2605873004: Unify MockExecutive and MockExecutive2. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify MockExecutive and MockExecutive2. After this, there's no choice between MockExecutive and MockExecutive2. This was preceded by preparation CL http://crrev.com/2588863002. BUG=626115 Committed: https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f Cr-Commit-Position: refs/heads/master@{#441181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -102 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py View 3 chunks +1 line, -40 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py View 5 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 6 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
qyearsley
3 years, 11 months ago (2016-12-28 19:13:35 UTC) #3
jeffcarp
lgtm
3 years, 11 months ago (2017-01-03 18:24:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605873004/1
3 years, 11 months ago (2017-01-03 18:26:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fd03924866bf384071c5ef113b682ff1210ecfbe
3 years, 11 months ago (2017-01-03 19:34:30 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 19:35:31 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f
Cr-Commit-Position: refs/heads/master@{#441181}

Powered by Google App Engine
This is Rietveld 408576698