third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py - Issue 2605873004: Unify MockExecutive and MockExecutive2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py

Issue 2605873004: Unify MockExecutive and MockExecutive2. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py

index 0d331efefd759318133951813195fabad719d7af..d005b84b5eff68b6bc423d61e9be86d01156c703 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py

@@ -28,7 +28,7 @@

import optparse

-from webkitpy.common.system.executive_mock import MockExecutive2

+from webkitpy.common.system.executive_mock import MockExecutive

from webkitpy.layout_tests.models import test_run_results

from webkitpy.layout_tests.port import browser_test

from webkitpy.layout_tests.port import browser_test_driver

@@ -39,7 +39,7 @@ class _BrowserTestTestCaseMixin(object):

def test_check_sys_deps(self):

port = self.make_port()

- port._executive = MockExecutive2(exit_code=0)

+ port._executive = MockExecutive(exit_code=0) # pylint: disable=protected-access

self.assertEqual(port.check_sys_deps(needs_http=False), test_run_results.OK_EXIT_STATUS)

def test_driver_name_option(self):