third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py - Issue 2605873004: Unify MockExecutive and MockExecutive2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

Issue 2605873004: Unify MockExecutive and MockExecutive2. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

index 57c6b766261fe68ad0e9b94c42cc9690567c4021..806ca41ed9770547de2b96b9eaae11e299f28c44 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

@@ -4,9 +4,9 @@

import unittest

-from webkitpy.w3c.deps_updater import DepsUpdater

from webkitpy.common.host_mock import MockHost

-from webkitpy.common.system.executive_mock import MockExecutive2

+from webkitpy.common.system.executive_mock import MockExecutive

+from webkitpy.w3c.deps_updater import DepsUpdater

class DepsUpdaterTest(unittest.TestCase):

@@ -64,7 +64,7 @@ class DepsUpdaterTest(unittest.TestCase):

def test_cl_description_with_empty_environ(self):

host = MockHost()

- host.executive = MockExecutive2(output='Last commit message\n')

+ host.executive = MockExecutive(output='Last commit message\n')

updater = DepsUpdater(host)

description = updater._cl_description()

self.assertEqual(

@@ -76,7 +76,7 @@ class DepsUpdaterTest(unittest.TestCase):

def test_cl_description_with_environ_variables(self):

host = MockHost()

- host.executive = MockExecutive2(output='Last commit message\n')

+ host.executive = MockExecutive(output='Last commit message\n')

updater = DepsUpdater(host)

updater.host.environ['BUILDBOT_MASTERNAME'] = 'my.master'

updater.host.environ['BUILDBOT_BUILDERNAME'] = 'b'