third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py - Issue 2605873004: Unify MockExecutive and MockExecutive2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py

Issue 2605873004: Unify MockExecutive and MockExecutive2. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py

index 63d3aaef80dcb94caa5d91e115d32f4eac8a145c..f9811680ebb1560e19f49d778f53969878341d0e 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py

@@ -3,8 +3,9 @@

# found in the LICENSE file.

import unittest

from webkitpy.common.host_mock import MockHost

-from webkitpy.common.system.executive_mock import MockExecutive2

+from webkitpy.common.system.executive_mock import MockExecutive

from webkitpy.w3c.chromium_commit import ChromiumCommit

from webkitpy.w3c.test_exporter_unittest import mock_command_exec

@@ -21,7 +22,7 @@ class ChromiumCommitTest(unittest.TestCase):

def test_derives_sha_from_position(self):

host = MockHost()

- host.executive = MockExecutive2(output='deadbeefcafe')

+ host.executive = MockExecutive(output='deadbeefcafe')

pos = 'Cr-Commit-Position: refs/heads/master@{#789}'

chromium_commit = ChromiumCommit(host, position=pos)