third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py - Issue 2605873004: Unify MockExecutive and MockExecutive2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py

Issue 2605873004: Unify MockExecutive and MockExecutive2. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py

index 20085219ae4b88f4e9e6494f9a960e253fa2a6ee..e9edad6d97c45fd03e49d013124477bcfb328ede 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py

@@ -3,10 +3,11 @@

# found in the LICENSE file.

import unittest

-from webkitpy.w3c.local_wpt import LocalWPT

from webkitpy.common.host_mock import MockHost

-from webkitpy.common.system.executive_mock import MockExecutive2

+from webkitpy.common.system.executive_mock import MockExecutive

from webkitpy.common.system.filesystem_mock import MockFileSystem

+from webkitpy.w3c.local_wpt import LocalWPT

class LocalWPTTest(unittest.TestCase):

@@ -59,7 +60,7 @@ class LocalWPTTest(unittest.TestCase):

'123',

'9ea4fc353a4b1c11c6e524270b11baa4d1ddfde8',

]

- host.executive = MockExecutive2(run_command_fn=lambda _: return_vals.pop())

+ host.executive = MockExecutive(run_command_fn=lambda _: return_vals.pop())

host.filesystem = MockFileSystem()

local_wpt = LocalWPT(host, no_fetch=True)

@@ -70,7 +71,7 @@ class LocalWPTTest(unittest.TestCase):

def test_last_wpt_exported_commit_not_found(self):

host = MockHost()

- host.executive = MockExecutive2(run_command_fn=lambda _: None)

+ host.executive = MockExecutive(run_command_fn=lambda _: None)

host.filesystem = MockFileSystem()

local_wpt = LocalWPT(host)