Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2604733002: SharedWorker: Make shared workers keyed by a pair of url and name (Closed)

Created:
3 years, 12 months ago by nhiroki
Modified:
3 years, 11 months ago
Reviewers:
kinuko, haraken
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SharedWorker: Make shared workers keyed by a pair of url and name This patch makes shared workers keyed by a pair of url and name, and deprecates URLMismatchError that was deleted from the spec: https://github.com/whatwg/html/pull/175 Before this change, shared workers throws URLMismatchError when a given worker's name is equal to an existing shared worker but a given script URL is different. After this change, a new shared worker is simply created in the case. BUG=538914 Committed: https://crrev.com/a2f777316c98a1bcc06f2d34120b7bec2c86a237 Cr-Commit-Position: refs/heads/master@{#440729}

Patch Set 1 #

Patch Set 2 : fix layout tests #

Patch Set 3 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -73 lines) Patch
M content/browser/shared_worker/shared_worker_instance.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/shared_worker/shared_worker_instance_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_message_filter.cc View 2 chunks +1 line, -10 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl_unittest.cc View 4 chunks +78 lines, -21 lines 0 comments Download
M content/renderer/shared_worker_repository.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/workers/shared-worker-shared.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/workers/shared-worker-shared-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorker.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorkerRepositoryClient.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp View 3 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/public/web/WebSharedWorkerCreationErrors.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebSharedWorkerRepositoryClient.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (26 generated)
nhiroki
Hi, can you review this? +kinuko@ for the entire changes +haraken@ for blink changes Thanks.
3 years, 12 months ago (2016-12-26 11:11:27 UTC) #10
kinuko
lgtm
3 years, 12 months ago (2016-12-27 02:21:27 UTC) #21
haraken
LGTM
3 years, 12 months ago (2016-12-27 02:44:31 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604733002/80001
3 years, 12 months ago (2016-12-27 04:01:00 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:80001)
3 years, 12 months ago (2016-12-27 04:10:23 UTC) #30
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:45:27 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a2f777316c98a1bcc06f2d34120b7bec2c86a237
Cr-Commit-Position: refs/heads/master@{#440729}

Powered by Google App Engine
This is Rietveld 408576698