Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: content/browser/shared_worker/shared_worker_message_filter.cc

Issue 2604733002: SharedWorker: Make shared workers keyed by a pair of url and name (Closed)
Patch Set: clean up Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/shared_worker/shared_worker_message_filter.cc
diff --git a/content/browser/shared_worker/shared_worker_message_filter.cc b/content/browser/shared_worker/shared_worker_message_filter.cc
index fd306ac47e5da613ce60c6098b3f1b62bb5be250..b80aaac0b49236de73e8c9bb2bbe9d52aab4e249 100644
--- a/content/browser/shared_worker/shared_worker_message_filter.cc
+++ b/content/browser/shared_worker/shared_worker_message_filter.cc
@@ -16,18 +16,11 @@
namespace content {
namespace {
+
const uint32_t kFilteredMessageClasses[] = {
ViewMsgStart, WorkerMsgStart,
};
-// TODO(estark): For now, only URLMismatch errors actually stop the
-// worker from being created. Other errors are recorded in UMA in
-// Blink but do not stop the worker from being created
-// yet. https://crbug.com/573206
-bool CreateWorkerErrorIsFatal(blink::WebWorkerCreationError error) {
- return (error == blink::WebWorkerCreationErrorURLMismatch);
-}
-
} // namespace
SharedWorkerMessageFilter::SharedWorkerMessageFilter(
@@ -93,8 +86,6 @@ void SharedWorkerMessageFilter::OnCreateWorker(
reply->error = SharedWorkerServiceImpl::GetInstance()->CreateWorker(
params, reply->route_id, this, resource_context_,
WorkerStoragePartitionId(partition_));
- if (CreateWorkerErrorIsFatal(reply->error))
- reply->route_id = MSG_ROUTING_NONE;
}
void SharedWorkerMessageFilter::OnForwardToWorker(const IPC::Message& message) {

Powered by Google App Engine
This is Rietveld 408576698