Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1973)

Unified Diff: content/browser/shared_worker/shared_worker_service_impl.cc

Issue 2604733002: SharedWorker: Make shared workers keyed by a pair of url and name (Closed)
Patch Set: clean up Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/shared_worker/shared_worker_service_impl.cc
diff --git a/content/browser/shared_worker/shared_worker_service_impl.cc b/content/browser/shared_worker/shared_worker_service_impl.cc
index 291df2c487247c79446b803cfe58713111af0ef7..6d8dfca611b305d605b9a706732ee94625c6f598 100644
--- a/content/browser/shared_worker/shared_worker_service_impl.cc
+++ b/content/browser/shared_worker/shared_worker_service_impl.cc
@@ -311,8 +311,6 @@ blink::WebWorkerCreationError SharedWorkerServiceImpl::CreateWorker(
filter, route_id, params.document_id, filter->render_process_id(),
params.render_frame_route_id));
if (SharedWorkerPendingInstance* pending = FindPendingInstance(*instance)) {
- if (params.url != pending->instance()->url())
- return blink::WebWorkerCreationErrorURLMismatch;
pending->AddRequest(std::move(request));
if (params.creation_context_type !=
pending->instance()->creation_context_type())
@@ -493,8 +491,6 @@ SharedWorkerServiceImpl::ReserveRenderProcessToCreateWorker(
blink::WebWorkerCreationErrorNone;
SharedWorkerHost* host = FindSharedWorkerHost(*pending_instance->instance());
if (host) {
- if (pending_instance->instance()->url() != host->instance()->url())
- return blink::WebWorkerCreationErrorURLMismatch;
if (pending_instance->instance()->creation_context_type() !=
host->instance()->creation_context_type()) {
creation_error = blink::WebWorkerCreationErrorSecureContextMismatch;

Powered by Google App Engine
This is Rietveld 408576698