Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Unified Diff: third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp

Issue 2604733002: SharedWorker: Make shared workers keyed by a pair of url and name (Closed)
Patch Set: clean up Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp b/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp
index 7a1414cd7a28c6fd4e3d13fde919e03060cf020a..1dbbfdfa6d3c5201102beb29ad4e27e1eeffe442 100644
--- a/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp
+++ b/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp
@@ -30,9 +30,6 @@
#include "web/SharedWorkerRepositoryClientImpl.h"
-#include "bindings/core/v8/ExceptionMessages.h"
-#include "bindings/core/v8/ExceptionState.h"
-#include "core/dom/ExceptionCode.h"
#include "core/dom/ExecutionContext.h"
#include "core/events/Event.h"
#include "core/frame/UseCounter.h"
@@ -114,8 +111,7 @@ void SharedWorkerRepositoryClientImpl::connect(
SharedWorker* worker,
WebMessagePortChannelUniquePtr port,
const KURL& url,
- const String& name,
- ExceptionState& exceptionState) {
+ const String& name) {
DCHECK(m_client);
// No nested workers (for now) - connect() should only be called from document
@@ -151,14 +147,6 @@ void SharedWorkerRepositoryClientImpl::connect(
switch (creationError) {
case WebWorkerCreationErrorNone:
break;
- case WebWorkerCreationErrorURLMismatch:
- // Existing worker does not match this url, so return an error back to the
- // caller.
- exceptionState.throwDOMException(
- URLMismatchError, "The location of the SharedWorker named '" + name +
- "' does not exactly match the provided URL ('" +
- url.elidedString() + "').");
- return;
case WebWorkerCreationErrorSecureContextMismatch:
UseCounter::Feature feature =
isSecureContext

Powered by Google App Engine
This is Rietveld 408576698