content/renderer/shared_worker_repository.cc - Issue 2604733002: SharedWorker: Make shared workers keyed by a pair of url and name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/shared_worker_repository.cc

Issue 2604733002: SharedWorker: Make shared workers keyed by a pair of url and name (Closed)

Patch Set: clean up Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/shared_worker_repository.cc

diff --git a/content/renderer/shared_worker_repository.cc b/content/renderer/shared_worker_repository.cc

index 96bea06fa5908ab341b35782bd78c0f47f958c95..01903b1388fb2ab06d6b146585e03abf1be5e4eb 100644

--- a/content/renderer/shared_worker_repository.cc

+++ b/content/renderer/shared_worker_repository.cc

@@ -42,8 +42,6 @@ SharedWorkerRepository::createSharedWorkerConnector(

ViewHostMsg_CreateWorker_Reply reply;

Send(new ViewHostMsg_CreateWorker(params, &reply));

*error = reply.error;

- if (reply.route_id == MSG_ROUTING_NONE)

- return nullptr;

documents_with_workers_.insert(document_id);

return base::MakeUnique<WebSharedWorkerProxy>(

ChildThreadImpl::current()->GetRouter(), reply.route_id);