Files app: Compile custom elements.

Files app: Compile custom elements.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2602693002
Cr-Commit-Position: refs/heads/master@{#442505}
Committed: https://chromium.googlesource.com/chromium/src/+/f86a2efa1d918dba8ff56fb575e9cd5751a81c28

[fukino, 2016-12-26 10:12:22]

Description was changed from

==========
Files app: Compile custom elements.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
==========

to

==========
Files app: Compile custom elements.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-12-26 10:14:50]

fukino@chromium.org changed reviewers:
+ oka@chromium.org

[oka, 2016-12-26 10:33:13]

https://codereview.chromium.org/2602693002/diff/20001/ui/file_manager/audio_p...
File ui/file_manager/audio_player/elements/control_panel.js (right):

https://codereview.chromium.org/2602693002/diff/20001/ui/file_manager/audio_p...
ui/file_manager/audio_player/elements/control_panel.js:140: type: Object,
Why don't you update Obejct to AriaLabels?
Then you can remove L300. Or add TODO to do so.

https://codereview.chromium.org/2602693002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp
(right):

https://codereview.chromium.org/2602693002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp:48:
'<(DEPTH)/ui/file_manager/externs/compiled_resources2.gyp:web_animation',
Maybe we could say
'<(EXTERNS_GYP):web_animations'
instead? Then remove externs/web_animation.js.

[fukino, 2016-12-26 11:32:22]

https://codereview.chromium.org/2602693002/diff/20001/ui/file_manager/audio_p...
File ui/file_manager/audio_player/elements/control_panel.js (right):

https://codereview.chromium.org/2602693002/diff/20001/ui/file_manager/audio_p...
ui/file_manager/audio_player/elements/control_panel.js:140: type: Object,
On 2016/12/26 10:33:12, oka wrote:
> Why don't you update Obejct to AriaLabels?
> Then you can remove L300. Or add TODO to do so.

Done. Adding annotation for ariaLabels worked. Thanks!

https://codereview.chromium.org/2602693002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp
(right):

https://codereview.chromium.org/2602693002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp:48:
'<(DEPTH)/ui/file_manager/externs/compiled_resources2.gyp:web_animation',
On 2016/12/26 10:33:12, oka wrote:
> Maybe we could say
> '<(EXTERNS_GYP):web_animations'
> instead? Then remove externs/web_animation.js.

We can use '<(EXTERNS_GYP):web_animations' by adding a missing property.
Removed own web_animation.js.

[fukino, 2016-12-26 11:34:05]

fukino@chromium.org changed reviewers:
+ dbeam@chromium.org

[fukino, 2016-12-26 11:34:06]

dbeam@: PTAL at third_party/closure_compiler/externs/web_animations.js.
To keep the extern file "Minimal", I didn't add other missing properties.
Please let me know if I should add Animation.ready, Animation.playState.

[oka, 2016-12-26 11:38:38]

LGTM with nit.

https://codereview.chromium.org/2602693002/diff/40001/ui/file_manager/audio_p...
File ui/file_manager/audio_player/elements/control_panel.js (right):

https://codereview.chromium.org/2602693002/diff/40001/ui/file_manager/audio_p...
ui/file_manager/audio_player/elements/control_panel.js:6: * @typedef {?{
nit: Can you remove ? here and add ? to @type {AriaLabels} ?

[fukino, 2016-12-26 11:44:43]

https://codereview.chromium.org/2602693002/diff/40001/ui/file_manager/audio_p...
File ui/file_manager/audio_player/elements/control_panel.js (right):

https://codereview.chromium.org/2602693002/diff/40001/ui/file_manager/audio_p...
ui/file_manager/audio_player/elements/control_panel.js:6: * @typedef {?{
On 2016/12/26 11:38:38, oka wrote:
> nit: Can you remove ? here and add ? to @type {AriaLabels} ?

This is a common pattern for typedefs of record types.
The header comment of chrome_extensions.js have more details.
https://codesearch.chromium.org/chromium/src/third_party/closure_compiler/ext...

[Dan Beam, 2016-12-29 20:15:43]

lgtm

[fukino, 2017-01-10 01:20:23]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2017-01-10 01:21:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 03:24:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:24:14]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[fukino, 2017-01-10 05:41:44]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2017-01-10 05:42:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 05:56:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484026904622920,
"parent_rev": "87a1099910617ebc70cc1a5e99bd738c29270725", "commit_rev":
"f86a2efa1d918dba8ff56fb575e9cd5751a81c28"}

[commit-bot: I haz the power, 2017-01-10 05:56:48]

Description was changed from

==========
Files app: Compile custom elements.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files app: Compile custom elements.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2602693002
Cr-Commit-Position: refs/heads/master@{#442505}
Committed:
https://chromium.googlesource.com/chromium/src/+/f86a2efa1d918dba8ff56fb575e9...
==========

[commit-bot: I haz the power, 2017-01-10 05:56:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f86a2efa1d918dba8ff56fb575e9...