Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2602693002: Files app: Compile custom elements. (Closed)

Created:
3 years, 12 months ago by fukino
Modified:
3 years, 11 months ago
Reviewers:
oka, Dan Beam
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files app: Compile custom elements. BUG=636289 TEST=run third_party/closure_compiler/run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2602693002 Cr-Commit-Position: refs/heads/master@{#442505} Committed: https://chromium.googlesource.com/chromium/src/+/f86a2efa1d918dba8ff56fb575e9cd5751a81c28

Patch Set 1 #

Patch Set 2 : Sort dependencies. #

Total comments: 4

Patch Set 3 : Address review comments. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -67 lines) Patch
M third_party/closure_compiler/externs/web_animations.js View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/file_manager/audio_player/elements/compiled_resources2.gyp View 1 1 chunk +34 lines, -20 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.js View 1 2 2 chunks +19 lines, -0 lines 2 comments Download
M ui/file_manager/compiled_resources2.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp View 1 2 1 chunk +57 lines, -44 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_safe_media.js View 1 chunk +2 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_toast.js View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (8 generated)
fukino
3 years, 12 months ago (2016-12-26 10:14:51 UTC) #3
oka
https://codereview.chromium.org/2602693002/diff/20001/ui/file_manager/audio_player/elements/control_panel.js File ui/file_manager/audio_player/elements/control_panel.js (right): https://codereview.chromium.org/2602693002/diff/20001/ui/file_manager/audio_player/elements/control_panel.js#newcode140 ui/file_manager/audio_player/elements/control_panel.js:140: type: Object, Why don't you update Obejct to AriaLabels? ...
3 years, 12 months ago (2016-12-26 10:33:13 UTC) #4
fukino
https://codereview.chromium.org/2602693002/diff/20001/ui/file_manager/audio_player/elements/control_panel.js File ui/file_manager/audio_player/elements/control_panel.js (right): https://codereview.chromium.org/2602693002/diff/20001/ui/file_manager/audio_player/elements/control_panel.js#newcode140 ui/file_manager/audio_player/elements/control_panel.js:140: type: Object, On 2016/12/26 10:33:12, oka wrote: > Why ...
3 years, 12 months ago (2016-12-26 11:32:22 UTC) #5
fukino
dbeam@: PTAL at third_party/closure_compiler/externs/web_animations.js. To keep the extern file "Minimal", I didn't add other missing ...
3 years, 12 months ago (2016-12-26 11:34:06 UTC) #7
oka
LGTM with nit. https://codereview.chromium.org/2602693002/diff/40001/ui/file_manager/audio_player/elements/control_panel.js File ui/file_manager/audio_player/elements/control_panel.js (right): https://codereview.chromium.org/2602693002/diff/40001/ui/file_manager/audio_player/elements/control_panel.js#newcode6 ui/file_manager/audio_player/elements/control_panel.js:6: * @typedef {?{ nit: Can you ...
3 years, 12 months ago (2016-12-26 11:38:38 UTC) #8
fukino
https://codereview.chromium.org/2602693002/diff/40001/ui/file_manager/audio_player/elements/control_panel.js File ui/file_manager/audio_player/elements/control_panel.js (right): https://codereview.chromium.org/2602693002/diff/40001/ui/file_manager/audio_player/elements/control_panel.js#newcode6 ui/file_manager/audio_player/elements/control_panel.js:6: * @typedef {?{ On 2016/12/26 11:38:38, oka wrote: > ...
3 years, 12 months ago (2016-12-26 11:44:43 UTC) #9
Dan Beam
lgtm
3 years, 11 months ago (2016-12-29 20:15:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602693002/40001
3 years, 11 months ago (2017-01-10 01:21:39 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 11 months ago (2017-01-10 03:24:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602693002/40001
3 years, 11 months ago (2017-01-10 05:42:22 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 05:56:49 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f86a2efa1d918dba8ff56fb575e9...

Powered by Google App Engine
This is Rietveld 408576698