Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: ui/file_manager/audio_player/elements/control_panel.js

Issue 2602693002: Files app: Compile custom elements. (Closed)
Patch Set: Address review comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/audio_player/elements/control_panel.js
diff --git a/ui/file_manager/audio_player/elements/control_panel.js b/ui/file_manager/audio_player/elements/control_panel.js
index ad142fd1736e95a245a778fb29f11f2612f577ce..2de3266c2905b3de994b002d5333e1648ef1c860 100644
--- a/ui/file_manager/audio_player/elements/control_panel.js
+++ b/ui/file_manager/audio_player/elements/control_panel.js
@@ -2,6 +2,24 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+/**
+ * @typedef {?{
oka 2016/12/26 11:38:38 nit: Can you remove ? here and add ? to @type {Ari
fukino 2016/12/26 11:44:43 This is a common pattern for typedefs of record ty
+ * mute: string,
+ * next: string,
+ * pause: string,
+ * play: string,
+ * playList: string,
+ * previous: string,
+ * repeat: string,
+ * seekSlider: string,
+ * shuffle: string,
+ * unmute: string,
+ * volume: string,
+ * volumeSlider: string,
+ * }}
+ */
+var AriaLabels;
+
(function() {
'use strict';
@@ -117,6 +135,7 @@
/**
* Dictionary which contains aria-labels for each controls.
+ * @type {AriaLabels}
*/
ariaLabels: {
type: Object,
« no previous file with comments | « ui/file_manager/audio_player/elements/compiled_resources2.gyp ('k') | ui/file_manager/compiled_resources2.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698