Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2606663002: Files app: Compile common/js/util.js (Closed)

Created:
3 years, 12 months ago by fukino
Modified:
3 years, 12 months ago
Reviewers:
oka
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files app: Compile common/js/util.js BUG=636289 TEST=run third_party/closure_compiler/run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/564d27aacd3d09a7cb97f2463abab1dec36b4bb2 Cr-Commit-Position: refs/heads/master@{#440707}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove redundant appID. #

Messages

Total messages: 15 (7 generated)
fukino
3 years, 12 months ago (2016-12-26 08:48:57 UTC) #3
oka
LGMT with nit.
3 years, 12 months ago (2016-12-26 09:06:03 UTC) #4
oka
On 2016/12/26 09:06:03, oka wrote: > LGMT with nit. LGTM
3 years, 12 months ago (2016-12-26 09:06:15 UTC) #5
oka
https://codereview.chromium.org/2606663002/diff/1/ui/file_manager/externs/app_window_common.js File ui/file_manager/externs/app_window_common.js (right): https://codereview.chromium.org/2606663002/diff/1/ui/file_manager/externs/app_window_common.js#newcode1 ui/file_manager/externs/app_window_common.js:1: // Copyright 2016 The Chromium Authors. All rights reserved. ...
3 years, 12 months ago (2016-12-26 09:10:27 UTC) #6
fukino
Thanks! https://codereview.chromium.org/2606663002/diff/1/ui/file_manager/externs/app_window_common.js File ui/file_manager/externs/app_window_common.js (right): https://codereview.chromium.org/2606663002/diff/1/ui/file_manager/externs/app_window_common.js#newcode1 ui/file_manager/externs/app_window_common.js:1: // Copyright 2016 The Chromium Authors. All rights ...
3 years, 12 months ago (2016-12-26 09:36:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606663002/20001
3 years, 12 months ago (2016-12-26 09:37:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-26 10:03:01 UTC) #13
commit-bot: I haz the power
3 years, 12 months ago (2016-12-26 10:06:23 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/564d27aacd3d09a7cb97f2463abab1dec36b4bb2
Cr-Commit-Position: refs/heads/master@{#440707}

Powered by Google App Engine
This is Rietveld 408576698