Files app: Compile common/js/util.js

Files app: Compile common/js/util.js

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/564d27aacd3d09a7cb97f2463abab1dec36b4bb2
Cr-Commit-Position: refs/heads/master@{#440707}

[fukino, 2016-12-26 08:48:24]

Description was changed from

==========
Files app: Compile common/js/util.js

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
==========

to

==========
Files app: Compile common/js/util.js

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-12-26 08:48:56]

fukino@chromium.org changed reviewers:
+ oka@chromium.org

[oka, 2016-12-26 09:06:03]

LGMT with nit.

[oka, 2016-12-26 09:06:15]

On 2016/12/26 09:06:03, oka wrote:
> LGMT with nit.

LGTM

[oka, 2016-12-26 09:10:27]

https://codereview.chromium.org/2606663002/diff/1/ui/file_manager/externs/app...
File ui/file_manager/externs/app_window_common.js (right):

https://codereview.chromium.org/2606663002/diff/1/ui/file_manager/externs/app...
ui/file_manager/externs/app_window_common.js:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
Can you remove Window.prototype.appID;
in externs/audio_player_foreground.js, gallery_foreground.js,
video_player_foreground.js, gallery_background.js.

[fukino, 2016-12-26 09:36:23]

Thanks!

https://codereview.chromium.org/2606663002/diff/1/ui/file_manager/externs/app...
File ui/file_manager/externs/app_window_common.js (right):

https://codereview.chromium.org/2606663002/diff/1/ui/file_manager/externs/app...
ui/file_manager/externs/app_window_common.js:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
On 2016/12/26 09:10:27, oka wrote:
> Can you remove Window.prototype.appID;
> in externs/audio_player_foreground.js, gallery_foreground.js,
> video_player_foreground.js, gallery_background.js.

Done.

[fukino, 2016-12-26 09:36:46]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-12-26 09:36:47]

The patchset sent to the CQ was uploaded after l-g-t-m from oka@chromium.org
Link to the patchset: https://codereview.chromium.org/2606663002/#ps20001
(title: "Remove redundant appID.")

[commit-bot: I haz the power, 2016-12-26 09:37:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-26 10:02:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482745006825510,
"parent_rev": "79897f3f4c7557f57283a82e46d4f2cd8717bdf6", "commit_rev":
"d8af8616022076b6b9d2977b2f8063c237f955c6"}

[commit-bot: I haz the power, 2016-12-26 10:03:00]

Description was changed from

==========
Files app: Compile common/js/util.js

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files app: Compile common/js/util.js

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2606663002
==========

[commit-bot: I haz the power, 2016-12-26 10:03:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-26 10:06:22]

Description was changed from

==========
Files app: Compile common/js/util.js

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2606663002
==========

to

==========
Files app: Compile common/js/util.js

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/564d27aacd3d09a7cb97f2463abab1dec36b4bb2
Cr-Commit-Position: refs/heads/master@{#440707}
==========

[commit-bot: I haz the power, 2016-12-26 10:06:23]

Patchset 2 (id:??) landed as
https://crrev.com/564d27aacd3d09a7cb97f2463abab1dec36b4bb2
Cr-Commit-Position: refs/heads/master@{#440707}