ui/file_manager/file_manager/foreground/elements/files_safe_media.js - Issue 2602693002: Files app: Compile custom elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/elements/files_safe_media.js

Issue 2602693002: Files app: Compile custom elements. (Closed)

Patch Set: Address review comments. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/file_manager/audio_player/elements/control_panel.js ('K') | « ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp ('k') | ui/file_manager/file_manager/foreground/elements/files_toast.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/elements/files_safe_media.js

diff --git a/ui/file_manager/file_manager/foreground/elements/files_safe_media.js b/ui/file_manager/file_manager/foreground/elements/files_safe_media.js

index beaf05f693d9cced947ec9294942e6ffc0b4c44a..4537141b07aaf4399f76b06e3dd01b05ceb84651 100644

--- a/ui/file_manager/file_manager/foreground/elements/files_safe_media.js

+++ b/ui/file_manager/file_manager/foreground/elements/files_safe_media.js

@@ -52,7 +52,8 @@ var FilesSafeMedia = Polymer({

this.webview_ = null;

} else if (this.src && !this.webview_) {

// Create webview node only if src exists to save resouces.

- var webview = document.createElement('webview');

+ var webview =

+ /** @type {!HTMLElement} */ (document.createElement('webview'));

this.webview_ = webview;

webview.partition = 'trusted';

webview.allowtransparency = 'true';