Files.app: Compile file_manager/foreground/js/metadata in v2 syntax.

Files.app: Compile file_manager/foreground/js/metadata in v2 syntax.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2607453002
Cr-Commit-Position: refs/heads/master@{#442563}
Committed: https://chromium.googlesource.com/chromium/src/+/c1a7078994c97ac791bdd45abec4fdce33900901

[fukino, 2016-12-26 10:30:41]

Description was changed from

==========
Files.app: Compile file_manager/foreground/js/metadata in v2 syntax.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
==========

to

==========
Files.app: Compile file_manager/foreground/js/metadata in v2 syntax.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-12-26 10:45:10]

The CQ bit was checked by fukino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-26 10:45:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-26 11:08:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-26 11:08:49]

Dry run: This issue passed the CQ dry run.

[fukino, 2016-12-26 11:36:16]

fukino@chromium.org changed reviewers:
+ dbeam@chromium.org, oka@chromium.org

[fukino, 2016-12-26 11:36:16]

dbeam@: PTAL at 	third_party/closure_compiler/compile2.py.
external_xxx.js was accidentally detected as externs file, so I'd like to make
this change.

oka@: PTAL at everything else.

[oka, 2016-12-26 12:28:28]

LGTM with nits.

https://codereview.chromium.org/2607453002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/metadata/metadata_dispatcher.js
(right):

https://codereview.chromium.org/2607453002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata/metadata_dispatcher.js:56: *
List of registered parser classes.
Maybe you can say
@private {Array<function(!MetadataDispatcher)>}
here and then revert edit in L42?

https://codereview.chromium.org/2607453002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/metadata/metadata_parser.js
(right):

https://codereview.chromium.org/2607453002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata/metadata_parser.js:5: 
Revert.

[Dan Beam, 2016-12-29 20:16:57]

heh, knew that'd bit us eventually

lgtm

[Dan Beam, 2016-12-29 20:17:05]

On 2016/12/29 20:16:57, Dan Beam wrote:
> heh, knew that'd bit us eventually
> 
> lgtm

bite*

[fukino, 2017-01-10 10:54:33]

Thanks!

https://codereview.chromium.org/2607453002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/metadata/metadata_dispatcher.js
(right):

https://codereview.chromium.org/2607453002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata/metadata_dispatcher.js:56: *
List of registered parser classes.
On 2016/12/26 12:28:28, oka wrote:
> Maybe you can say
> @private {Array<function(!MetadataDispatcher)>}
> here and then revert edit in L42?

Done.
I used {!Array<function(new:MetadataParser, !MetadataParserLogger)>} to use the
elements as constructors.

https://codereview.chromium.org/2607453002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/metadata/metadata_parser.js
(right):

https://codereview.chromium.org/2607453002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata/metadata_parser.js:5: 
On 2016/12/26 12:28:28, oka wrote:
> Revert.

Done.

[fukino, 2017-01-10 10:54:39]

The CQ bit was checked by fukino@chromium.org

[fukino, 2017-01-10 10:54:40]

The patchset sent to the CQ was uploaded after l-g-t-m from oka@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2607453002/#ps40001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-01-10 10:54:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 10:56:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 10:56:38]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[fukino, 2017-01-10 12:11:55]

The CQ bit was checked by fukino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 12:12:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 12:44:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 12:44:40]

Dry run: This issue passed the CQ dry run.

[fukino, 2017-01-10 12:49:30]

The CQ bit was checked by fukino@chromium.org

[fukino, 2017-01-10 12:49:31]

The patchset sent to the CQ was uploaded after l-g-t-m from oka@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2607453002/#ps80001
(title: "Re-rebase (PS4 had unrelated changes.)")

[commit-bot: I haz the power, 2017-01-10 12:49:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 12:53:42]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484052570607420,
"parent_rev": "aa4e14837187e3c65d9175961d6e8ce3ca013f3c", "commit_rev":
"c1a7078994c97ac791bdd45abec4fdce33900901"}

[commit-bot: I haz the power, 2017-01-10 12:54:10]

Description was changed from

==========
Files.app: Compile file_manager/foreground/js/metadata in v2 syntax.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files.app: Compile file_manager/foreground/js/metadata in v2 syntax.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2607453002
Cr-Commit-Position: refs/heads/master@{#442563}
Committed:
https://chromium.googlesource.com/chromium/src/+/c1a7078994c97ac791bdd45abec4...
==========

[commit-bot: I haz the power, 2017-01-10 12:54:12]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c1a7078994c97ac791bdd45abec4...