Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2598353002: The second argument of add/removeEventListener should be an object, null, or undefined

Created:
3 years, 12 months ago by bashi
Modified:
3 years, 11 months ago
Reviewers:
haraken, kinuko, Dan Beam, Yuki
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The second argument of add/removeEventListener should be an object, null, or undefined Throw a TypeError if the second argument is other than an object, null, or undefined. BUG=676845

Patch Set 1 #

Patch Set 2 : Fix test #

Total comments: 1

Patch Set 3 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -16 lines) Patch
M chrome/browser/ui/webui/options/options_browsertest.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/print_preview.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/loader/async_resource_handler.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/event-target-add-remove-listeners.html View 1 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/onclick-list-marker.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_attributes.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_types.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
bashi
PTAL yukishiino, haraken: all changes kinuko: trivial change in content/test/data https://codereview.chromium.org/2598353002/diff/20001/content/test/data/loader/async_resource_handler.html File content/test/data/loader/async_resource_handler.html (left): https://codereview.chromium.org/2598353002/diff/20001/content/test/data/loader/async_resource_handler.html#oldcode38 ...
3 years, 12 months ago (2016-12-27 08:37:17 UTC) #8
haraken
LGTM
3 years, 12 months ago (2016-12-27 08:54:37 UTC) #9
Yuki
LGTM.
3 years, 12 months ago (2016-12-27 09:33:17 UTC) #10
kinuko
lgtm
3 years, 12 months ago (2016-12-27 15:29:24 UTC) #13
kinuko
Test failures look relevant.
3 years, 12 months ago (2016-12-27 15:31:01 UTC) #14
bashi
dbeam@: could you review the fix in js files used by browser tests?
3 years, 11 months ago (2017-01-05 00:51:01 UTC) #18
Dan Beam
3 years, 11 months ago (2017-01-05 02:27:18 UTC) #21
lgtm

Powered by Google App Engine
This is Rietveld 408576698